Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-aws_ecs_account_setting_default support for fargateTaskRetirementWaitPeriod #37018

Merged
merged 10 commits into from
May 11, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 20, 2024

Description

Relations

Closes #33422
Relates #35796

References

Output from Acceptance Testing

% make testacc TESTS=TestAccECSAccountSettingDefault_serial PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSAccountSettingDefault_serial'  -timeout 360m
=== RUN   TestAccECSAccountSettingDefault_serial
=== PAUSE TestAccECSAccountSettingDefault_serial
=== CONT  TestAccECSAccountSettingDefault_serial
=== RUN   TestAccECSAccountSettingDefault_serial/containerInstanceLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_serial/serviceLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_serial/taskLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_serial/vpcTrunking
=== RUN   TestAccECSAccountSettingDefault_serial/containerInsights
=== RUN   TestAccECSAccountSettingDefault_serial/fargateTaskRetirementWaitPeriod
--- PASS: TestAccECSAccountSettingDefault_serial (155.23s)
    --- PASS: TestAccECSAccountSettingDefault_serial/containerInstanceLongARNFormat (24.30s)
    --- PASS: TestAccECSAccountSettingDefault_serial/serviceLongARNFormat (21.09s)
    --- PASS: TestAccECSAccountSettingDefault_serial/taskLongARNFormat (22.54s)
    --- PASS: TestAccECSAccountSettingDefault_serial/vpcTrunking (24.04s)
    --- PASS: TestAccECSAccountSettingDefault_serial/containerInsights (35.04s)
    --- PASS: TestAccECSAccountSettingDefault_serial/fargateTaskRetirementWaitPeriod (28.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	169.367s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. labels Apr 20, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 20, 2024
@nikhil-goenka nikhil-goenka changed the title f-aws_ecs_account_setting_default f-aws_ecs_account_setting_default support for fargateTaskRetirementWaitPeriod Apr 20, 2024
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Apr 20, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 23, 2024
@nam054
Copy link
Contributor

nam054 commented May 11, 2024

LGTM 🚀 Thank you for your contribtuion!

> make testacc TESTS=TestAccECSAccountSettingDefault_serial PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSAccountSettingDefault_serial'  -timeout 360m
=== RUN   TestAccECSAccountSettingDefault_serial
=== PAUSE TestAccECSAccountSettingDefault_serial
=== CONT  TestAccECSAccountSettingDefault_serial
=== RUN   TestAccECSAccountSettingDefault_serial/containerInsights
=== RUN   TestAccECSAccountSettingDefault_serial/fargateTaskRetirementWaitPeriod
=== RUN   TestAccECSAccountSettingDefault_serial/containerInstanceLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_serial/serviceLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_serial/taskLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_serial/vpcTrunking
--- PASS: TestAccECSAccountSettingDefault_serial (73.80s)
    --- PASS: TestAccECSAccountSettingDefault_serial/containerInsights (12.66s)
    --- PASS: TestAccECSAccountSettingDefault_serial/fargateTaskRetirementWaitPeriod (12.28s)
    --- PASS: TestAccECSAccountSettingDefault_serial/containerInstanceLongARNFormat (12.25s)
    --- PASS: TestAccECSAccountSettingDefault_serial/serviceLongARNFormat (12.15s)
    --- PASS: TestAccECSAccountSettingDefault_serial/taskLongARNFormat (12.23s)
    --- PASS: TestAccECSAccountSettingDefault_serial/vpcTrunking (12.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        78.998s

@nam054 nam054 merged commit 948a506 into hashicorp:main May 11, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.50.0 milestone May 11, 2024
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@nikhil-goenka nikhil-goenka deleted the f-aws_ecs_account_setting_default branch June 16, 2024 13:01
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support fargateTaskRetirementWaitPeriod in ECS account defaults
3 participants