Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_bcmdataexports_export: fix error on table configuration #37205

Merged
merged 8 commits into from
May 1, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented May 1, 2024

Description

Relations

Closes #37126

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccBCMDataExportsExport_" PKG=bcmdataexports

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/bcmdataexports/... -v -count 1 -parallel 20  -run=TestAccBCMDataExportsExport_ -timeout 360m
--- PASS: TestAccBCMDataExportsExport_curSubset (18.99s)
--- PASS: TestAccBCMDataExportsExport_disappears (19.11s)
--- PASS: TestAccBCMDataExportsExport_basic (21.43s)
--- PASS: TestAccBCMDataExportsExport_update (29.31s)
--- PASS: TestAccBCMDataExportsExport_updateTable (31.95s)
--- PASS: TestAccBCMDataExportsExport_tags (41.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bcmdataexports	46.669s

Copy link

github-actions bot commented May 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 1, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 1, 2024
@johnsonaj
Copy link
Contributor Author

go test -count=1 ./internal/framework/flex/...
ok  	github.com/hashicorp/terraform-provider-aws/internal/framework/flex	0.461s

@johnsonaj johnsonaj added bug Addresses a defect in current functionality. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. labels May 1, 2024
@johnsonaj johnsonaj marked this pull request as ready for review May 1, 2024 15:37
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@@ -10,8 +10,6 @@ description: |-

Terraform resource for managing an AWS BCM Data Exports Export.

~> **NOTE:** Including `line_item_resource_id` in the SQL query in `export.0.data_query.0.query_statement` results in an error, `ValidationException: The columns in the query provided are not a subset of the table COST_AND_USAGE_REPORT`. Based on [AWS Documentation](https://docs.aws.amazon.com/cur/latest/userguide/data-dictionary.html), `line_item_resource_id` should be a valid column but is currently causing errors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnsonaj johnsonaj merged commit fc1b4b8 into main May 1, 2024
44 checks passed
@johnsonaj johnsonaj deleted the b-autoflex_expand_mapofstringmap branch May 1, 2024 17:03
@github-actions github-actions bot added this to the v5.48.0 milestone May 1, 2024
github-actions bot pushed a commit that referenced this pull request May 1, 2024
Copy link

github-actions bot commented May 2, 2024

This functionality has been released in v5.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 2, 2024
Copy link

github-actions bot commented Jun 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_bcmdataexports_export - CreateExport error - Columns are not a subset of table
2 participants