Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_opensearch_domain: add ip_address_type attribute #37237

Merged
merged 11 commits into from
Jun 12, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented May 2, 2024

Description

Relations

Closes #37228

References

Output from Acceptance Testing

% make testacc TESTS=TestAccOpenSearchDomain_ipAddressType PKG=opensearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/opensearch/... -v -count 1 -parallel 20 -run='TestAccOpenSearchDomain_ipAddressType'  -timeout 360m
=== RUN   TestAccOpenSearchDomain_ipAddressType
=== PAUSE TestAccOpenSearchDomain_ipAddressType
=== CONT  TestAccOpenSearchDomain_ipAddressType
--- PASS: TestAccOpenSearchDomain_ipAddressType (1922.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	1943.358s
--- PASS: TestAccOpenSearchDomain_duplicate (1252.70s)
--- PASS: TestAccOpenSearchDomain_Encryption_nodeToNode (1748.47s)
--- PASS: TestAccOpenSearchDomain_v23 (1838.17s)
--- PASS: TestAccOpenSearchDomain_Encryption_atRestSpecifyKey (1896.97s)
--- PASS: TestAccOpenSearchDomain_basic (1953.23s)
--- PASS: TestAccOpenSearchDomain_disappears (1989.73s)
--- PASS: TestAccOpenSearchDomain_Policy_ignoreEquivalent (2147.63s)
--- PASS: TestAccOpenSearchDomain_Policy_addPrincipal (2229.03s)
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_applicationLogs (2251.51s)
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_auditLogs (2272.03s)
--- PASS: TestAccOpenSearchDomain_complex (2282.53s)
--- PASS: TestAccOpenSearchDomain_VolumeType_gp3ToGP2 (2385.26s)
--- PASS: TestAccOpenSearchDomain_Policy_basic (2484.17s)
--- PASS: TestAccOpenSearchDomain_Encryption_atRestDefaultKey (2773.21s)
--- PASS: TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled (2811.02s)
--- PASS: TestAccOpenSearchDomain_softwareUpdateOptions (2556.45s)
--- PASS: TestAccOpenSearchDomain_VolumeType_missing (1785.19s)
--- PASS: TestAccOpenSearchDomain_CognitoOptions_update (3873.74s)
--- PASS: TestAccOpenSearchDomain_offPeakWindowOptions (2060.36s)
--- PASS: TestAccOpenSearchDomain_tags (2022.30s)
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_searchSlowLogs (2188.08s)
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_iam (2053.52s)
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_disabled (2507.52s)
--- PASS: TestAccOpenSearchDomain_Encryption_atRestEnableLegacy (5436.36s)
--- PASS: TestAccOpenSearchDomain_customEndpoint (2093.44s)
--- PASS: TestAccOpenSearchDomain_ipAddressType (1911.79s)
--- PASS: TestAccOpenSearchDomain_Encryption_atRestEnable (6059.44s)
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_indexSlowLogs (2137.03s)
--- PASS: TestAccOpenSearchDomain_Cluster_coldStorage (4023.20s)
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_userDB (2363.94s)
--- PASS: TestAccOpenSearchDomain_Cluster_update (4501.80s)
--- PASS: TestAccOpenSearchDomain_autoTuneOptions (1925.68s)
--- PASS: TestAccOpenSearchDomain_versionUpdate (5680.17s)
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_anonymousAuth (4959.98s)
--- PASS: TestAccOpenSearchDomain_requireHTTPS (2059.42s)
--- PASS: TestAccOpenSearchDomain_Encryption_nodeToNodeEnableLegacy (5282.78s)
--- PASS: TestAccOpenSearchDomain_Encryption_nodeToNodeEnable (5414.43s)
--- PASS: TestAccOpenSearchDomain_VPC_update (5945.41s)
...

Copy link

github-actions bot commented May 2, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/opensearch Issues and PRs that pertain to the opensearch service. labels May 2, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 2, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 6, 2024
@johnsonaj johnsonaj self-assigned this Jun 12, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 12, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccOpenSearchDomainDataSource_Data_basic" PKG=opensearch

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchDomainDataSource_Data_basic -timeout 360m
=== RUN   TestAccOpenSearchDomainDataSource_Data_basic
=== PAUSE TestAccOpenSearchDomainDataSource_Data_basic
=== CONT  TestAccOpenSearchDomainDataSource_Data_basic
--- PASS: TestAccOpenSearchDomainDataSource_Data_basic (2195.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	2201.138s
% make testacc TESTARGS="-run=TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomain_disappears" PKG=opensearch

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomain_disappears -timeout 360m
=== RUN   TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN   TestAccOpenSearchDomain_disappears
=== PAUSE TestAccOpenSearchDomain_disappears
=== CONT  TestAccOpenSearchDomain_basic
=== CONT  TestAccOpenSearchDomain_disappears
--- PASS: TestAccOpenSearchDomain_disappears (1797.63s)
--- PASS: TestAccOpenSearchDomain_basic (1810.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	1816.348s
% make testacc TESTARGS="-run=TestAccOpenSearchDomain_ipAddressType" PKG=opensearch

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchDomain_ipAddressType -timeout 360m
=== RUN   TestAccOpenSearchDomain_ipAddressType
=== PAUSE TestAccOpenSearchDomain_ipAddressType
=== CONT  TestAccOpenSearchDomain_ipAddressType
--- PASS: TestAccOpenSearchDomain_ipAddressType (3915.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	3920.778s

@johnsonaj johnsonaj changed the title aws_opensearch_domain r/aws_opensearch_domain: add ip_address_type attribute Jun 12, 2024
@johnsonaj
Copy link
Contributor

@nikhil-goenka thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 4fd2650 into hashicorp:main Jun 12, 2024
53 checks passed
@github-actions github-actions bot added this to the v5.54.0 milestone Jun 12, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 14, 2024
Copy link

This functionality has been released in v5.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/opensearch Issues and PRs that pertain to the opensearch service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for IPAddressType for OpenSearch domains
3 participants