Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/cognito_user_pool #37399

Merged
merged 18 commits into from
Jun 28, 2024
Merged

d/cognito_user_pool #37399

merged 18 commits into from
Jun 28, 2024

Conversation

danquack
Copy link
Contributor

@danquack danquack commented May 9, 2024

Description

Adds cognito user pool data source. Data source generated with skaff.

Relations

Closes #36087

Output from Acceptance Testing

%  TF_ACC=1 make testacc TESTS=TestAccCognitoIDPUserPoolDataSource_ PKG=cognitoidp                                                      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPoolDataSource_'  -timeout 360m
=== RUN   TestAccCognitoIDPUserPoolDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolDataSource_basic
=== RUN   TestAccCognitoIDPUserPoolDataSource_schemaAttributes
=== PAUSE TestAccCognitoIDPUserPoolDataSource_schemaAttributes
=== CONT  TestAccCognitoIDPUserPoolDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolDataSource_schemaAttributes
--- PASS: TestAccCognitoIDPUserPoolDataSource_schemaAttributes (30.12s)
--- PASS: TestAccCognitoIDPUserPoolDataSource_basic (30.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 34.883s
...

Copy link

github-actions bot commented May 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/XL Managed by automation to categorize the size of a PR. labels May 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 9, 2024
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels May 13, 2024
@danquack danquack requested a review from a team as a code owner June 28, 2024 14:04
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIDPUserPoolDataSource_' PKG=cognitoidp
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/cognitoidp/... -v -count 1 -parallel 20  -run=TestAccCognitoIDPUserPoolDataSource_ -timeout 360m
=== RUN   TestAccCognitoIDPUserPoolDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolDataSource_basic
=== RUN   TestAccCognitoIDPUserPoolDataSource_schemaAttributes
=== PAUSE TestAccCognitoIDPUserPoolDataSource_schemaAttributes
=== CONT  TestAccCognitoIDPUserPoolDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolDataSource_schemaAttributes
--- PASS: TestAccCognitoIDPUserPoolDataSource_basic (11.64s)
--- PASS: TestAccCognitoIDPUserPoolDataSource_schemaAttributes (11.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	16.168s

@ewbankkit
Copy link
Contributor

@danquack Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 433d931 into hashicorp:main Jun 28, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.57.0 milestone Jun 28, 2024
@danquack danquack deleted the 36087/cognito-ds branch June 28, 2024 20:45
@SolomonHD
Copy link

Great fix! 🚀
When does this change make it into a release?

Copy link

github-actions bot commented Jul 5, 2024

This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Aug 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Data Sources for Cognito User Pool
4 participants