Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add input argument to enable webserver auto scalling #37632

Conversation

JPSerras
Copy link

@JPSerras JPSerras commented May 22, 2024

Description

Added Webserver autoscaling input arguments to the module as AWS Mwaa now supports this feature.

Relations

References

https://aws.amazon.com/about-aws/whats-new/2024/05/amazon-mwaa-airflow-rest-api-web-server-auto-scaling/

Output from Acceptance Testing

% make testacc TESTS=TestAccMWAAEnvironment_full PKG=mwaa
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/mwaa/... -v -count 1 -parallel 20 -run='TestAccMWAAEnvironment_full'  -timeout 360m
=== RUN   TestAccMWAAEnvironment_full
=== PAUSE TestAccMWAAEnvironment_full
=== CONT  TestAccMWAAEnvironment_full

--- PASS: TestAccMWAAEnvironment_full (2666.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	2671.890s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/mwaa Issues and PRs that pertain to the mwaa service. labels May 22, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 22, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @JPSerras 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@JPSerras JPSerras force-pushed the f-aws_mwaa_environment-webservers-auto-scalling branch from 02692f2 to 2f81c44 Compare May 22, 2024 10:01
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@JPSerras JPSerras marked this pull request as ready for review May 22, 2024 12:16
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 24, 2024
@johnsonaj johnsonaj self-assigned this Jun 6, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 6, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccMWAAEnvironment_full' PKG=mwaa

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/mwaa/... -v -count 1 -parallel 20  -run=TestAccMWAAEnvironment_full -timeout 360m
--- PASS: TestAccMWAAEnvironment_full (3141.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	3148.015s

@johnsonaj
Copy link
Contributor

@JPSerras thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit e00f339 into hashicorp:main Jun 6, 2024
37 checks passed
@github-actions github-actions bot added this to the v5.53.0 milestone Jun 6, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@skpune
Copy link

skpune commented Jul 7, 2024

Hi Team,

Can we update the Argument Reference doc as well. Currently it is not stating that it supports argument for min and max number of webserver.

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/mwaa_environment

Copy link

github-actions bot commented Aug 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/mwaa Issues and PRs that pertain to the mwaa service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants