Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Data Source] Glue registry #37953

Merged
merged 20 commits into from
Sep 4, 2024
Merged

Conversation

Viriathus1
Copy link
Contributor

Description

Retrieve an existing Glue Registry in order to then create a Glue Schema in it.

Relations

Closes #36558

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/glue_schema
https://pkg.go.dev/github.com/hashicorp/terraform-provider-aws/internal/service/glue#FindRegistryByID

Output from Acceptance Testing

% make testacc TESTS=TestAccGlueRegistryDataSource_basic PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueRegistryDataSource_basic'  -timeout 360m
=== RUN   TestAccGlueRegistryDataSource_basic
=== PAUSE TestAccGlueRegistryDataSource_basic
=== CONT  TestAccGlueRegistryDataSource_basic
--- PASS: TestAccGlueRegistryDataSource_basic (10.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	18.086s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. generators Relates to code generators. labels Jun 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 13, 2024
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@Viriathus1 Viriathus1 changed the title F glue registry [New Data Source] Glue registry Jun 13, 2024
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 13, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccGlueRegistry_' PKG=glue

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/glue/... -v -count 1 -parallel 20  -run=TestAccGlueRegistry_ -timeout 360m
--- PASS: TestAccGlueRegistry_disappears (14.50s)
--- PASS: TestAccGlueRegistry_basic (16.23s)
--- PASS: TestAccGlueRegistry_tags (33.20s)
--- PASS: TestAccGlueRegistry_description (33.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	39.732s
% make testacc TESTARGS='-run=TestAccGlueRegistryDataSource_basic' PKG=glue

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/glue/... -v -count 1 -parallel 20  -run=TestAccGlueRegistryDataSource_basic -timeout 360m
=== RUN   TestAccGlueRegistryDataSource_basic
=== PAUSE TestAccGlueRegistryDataSource_basic
=== CONT  TestAccGlueRegistryDataSource_basic
--- PASS: TestAccGlueRegistryDataSource_basic (13.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	19.302s

@johnsonaj
Copy link
Contributor

@Viriathus1 thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 4456e71 into hashicorp:main Sep 4, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.66.0 milestone Sep 4, 2024
Copy link

github-actions bot commented Sep 5, 2024

This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@Viriathus1 Viriathus1 deleted the f-glue-registry branch September 6, 2024 00:07
Copy link

github-actions bot commented Oct 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/glue Issues and PRs that pertain to the glue service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: aws_glue_registry as data source
3 participants