Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Update maximum build_timeout for codebuild from 8 hours to 36 hours #37970

Merged

Conversation

WestonReed
Copy link
Contributor

@WestonReed WestonReed commented Jun 14, 2024

Description

The maximum timeout for AWS CodeBuild has been updated to 36 hours (2160 minutes). Update the provider configuration to allow setting values > 480. Currently, trying to set values > 480 will result in the following provider error:

Error: 
expected build_timeout to be in the range (5 - 480), got 2160

Relations

Fixes #37823

References

Quotas for AWS CodeBuild

Output from Acceptance Testing

make testacc TESTS=TestAccCodeBuildProject_buildBatchConfigDelete PKG=codebuild
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildProject_buildBatchConfigDelete'  -timeout 360m
=== RUN   TestAccCodeBuildProject_buildBatchConfigDelete
=== PAUSE TestAccCodeBuildProject_buildBatchConfigDelete
=== CONT  TestAccCodeBuildProject_buildBatchConfigDelete
--- PASS: TestAccCodeBuildProject_buildBatchConfigDelete (53.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	53.968s

@WestonReed WestonReed requested a review from a team as a code owner June 14, 2024 02:34
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codebuild Issues and PRs that pertain to the codebuild service. labels Jun 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 14, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @WestonReed 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@WestonReed WestonReed force-pushed the weston/fix-codebuild-timeout-maximum branch from d68357b to d9e8d06 Compare June 14, 2024 03:48
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 14, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCodeBuildProject_buildBatchConfigDelete\|TestAccCodeBuildProject_basic' PKG=codebuild
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/codebuild/... -v -count 1 -parallel 20  -run=TestAccCodeBuildProject_buildBatchConfigDelete\|TestAccCodeBuildProject_basic -timeout 360m
=== RUN   TestAccCodeBuildProject_basic
=== PAUSE TestAccCodeBuildProject_basic
=== RUN   TestAccCodeBuildProject_buildBatchConfigDelete
=== PAUSE TestAccCodeBuildProject_buildBatchConfigDelete
=== CONT  TestAccCodeBuildProject_basic
=== CONT  TestAccCodeBuildProject_buildBatchConfigDelete
=== NAME  TestAccCodeBuildProject_basic
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_basic (0.31s)
=== NAME  TestAccCodeBuildProject_buildBatchConfigDelete
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_buildBatchConfigDelete (0.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	4.614s

@ewbankkit
Copy link
Contributor

@WestonReed Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ea4ad9b into hashicorp:main Jun 14, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.55.0 milestone Jun 14, 2024
Copy link

This functionality has been released in v5.54.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: CodeBuild Timeout
4 participants