route53profiles - r/association, r/resource_association and d/profiles resources added

[aristosvo]

Description

Extra resources aws_route53profiles_association and aws_route53profiles_resource_association added on top of an open MR (#37124) for aws_route53profiles_profile. Besides that, added data source aws_route53profiles_profiles as profiles are shared via RAM with other accounts and lookup via the API is only possible via ID or as a list. Providing the ID to use the data source is more cumbersome than have a list showing all profiles on which you can filter client side (if necessary at all).

TODO:

• sweeper
• changelog
• data source aws_route53profiles_profiles -> profiles are shared via RAM with other accounts, lookup via the API is only possible via ID or as a list. Providing the ID to use the data source is more cumbersome than filter a list client side based on one of its attributes (name?).
• improve resource_properties json parsing

Relations

Improves #37124
Closes #37050

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRoute53ProfilesResourceAssociation_ PKG=route53profiles   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20 -run='TestAccRoute53ProfilesResourceAssociation_'  -timeout 360m
=== RUN   TestAccRoute53ProfilesResourceAssociation_basic
=== PAUSE TestAccRoute53ProfilesResourceAssociation_basic
=== RUN   TestAccRoute53ProfilesResourceAssociation_firewallRuleGroup
=== PAUSE TestAccRoute53ProfilesResourceAssociation_firewallRuleGroup
=== RUN   TestAccRoute53ProfilesResourceAssociation_resolverRule
=== PAUSE TestAccRoute53ProfilesResourceAssociation_resolverRule
=== RUN   TestAccRoute53ProfilesResourceAssociation_disappears
=== PAUSE TestAccRoute53ProfilesResourceAssociation_disappears
=== CONT  TestAccRoute53ProfilesResourceAssociation_basic
=== CONT  TestAccRoute53ProfilesResourceAssociation_resolverRule
=== CONT  TestAccRoute53ProfilesResourceAssociation_disappears
=== CONT  TestAccRoute53ProfilesResourceAssociation_firewallRuleGroup
--- PASS: TestAccRoute53ProfilesResourceAssociation_firewallRuleGroup (143.28s)
--- PASS: TestAccRoute53ProfilesResourceAssociation_resolverRule (166.51s)
--- PASS: TestAccRoute53ProfilesResourceAssociation_disappears (374.42s)
--- PASS: TestAccRoute53ProfilesResourceAssociation_basic (379.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    383.579s

% make testacc TESTS=TestAccRoute53ProfilesAssociation_ PKG=route53profiles    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20 -run='TestAccRoute53ProfilesAssociation_'  -timeout 360m
=== RUN   TestAccRoute53ProfilesAssociation_basic
=== PAUSE TestAccRoute53ProfilesAssociation_basic
=== RUN   TestAccRoute53ProfilesAssociation_disappears
=== PAUSE TestAccRoute53ProfilesAssociation_disappears
=== CONT  TestAccRoute53ProfilesAssociation_basic
=== CONT  TestAccRoute53ProfilesAssociation_disappears
--- PASS: TestAccRoute53ProfilesAssociation_basic (316.20s)
--- PASS: TestAccRoute53ProfilesAssociation_disappears (316.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    320.751s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[tdiener01]

Hello! My organization is very much looking forward to the Route 53 Profiles resources making it in. @justinretzolk I noticed you added labels a few weeks back, is there a rough time frame for incorporating this feature? Would love to use it soon, thanks!

[tonyhess]

@justinretzolk Is there a way to get this approved?

[tdiener01]

Looks like this one is just about ready for release, @justinretzolk could you comment on a possible timeframe for these resources making it in? Would greatly appreciate it!

[claytonolley]

I'm also badly in need of this functionality, just curious what the hold up is.

[Pacobart]

I solved for this using the awscc provider https://registry.terraform.io/providers/hashicorp/awscc/latest/docs/resources/route53profiles_profile
@claytonolley @tdiener01

[PacoVK]

I solved for this using the awscc provider https://registry.terraform.io/providers/hashicorp/awscc/latest/docs/resources/route53profiles_profile @claytonolley @tdiener01

That is a solution but take #37050 (comment) into account. Depending on your setup awscc is not a solution unfortunately :/ hope this get merged soon

[nam054]

LGTM 🚀 Thank you for your contribution!

> make testacc TESTARGS="-run=TestAccRoute53ProfilesProfile_" PKG=route53profiles
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/route53profiles/... -v -count 1 -parallel 20  -run=TestAccRoute53ProfilesProfile_ -timeout 360m
=== RUN   TestAccRoute53ProfilesProfile_basic
=== PAUSE TestAccRoute53ProfilesProfile_basic
=== RUN   TestAccRoute53ProfilesProfile_disappears
=== PAUSE TestAccRoute53ProfilesProfile_disappears
=== RUN   TestAccRoute53ProfilesProfile_tags
=== PAUSE TestAccRoute53ProfilesProfile_tags
=== CONT  TestAccRoute53ProfilesProfile_basic
=== CONT  TestAccRoute53ProfilesProfile_tags
=== CONT  TestAccRoute53ProfilesProfile_disappears
--- PASS: TestAccRoute53ProfilesProfile_disappears (13.26s)
--- PASS: TestAccRoute53ProfilesProfile_basic (15.70s)
--- PASS: TestAccRoute53ProfilesProfile_tags (15.73s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    20.893s

> make testacc TESTARGS="-run=TestAccRoute53ProfilesAssociation_" PKG=route53profiles
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/route53profiles/... -v -count 1 -parallel 20  -run=TestAccRoute53ProfilesAssociation_ -timeout 360m
=== RUN   TestAccRoute53ProfilesAssociation_basic
=== PAUSE TestAccRoute53ProfilesAssociation_basic
=== RUN   TestAccRoute53ProfilesAssociation_disappears
=== PAUSE TestAccRoute53ProfilesAssociation_disappears
=== CONT  TestAccRoute53ProfilesAssociation_basic
=== CONT  TestAccRoute53ProfilesAssociation_disappears
--- PASS: TestAccRoute53ProfilesAssociation_disappears (273.91s)
--- PASS: TestAccRoute53ProfilesAssociation_basic (274.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    279.595s

> make testacc TESTARGS="-run=TestAccRoute53ProfilesResourceAssociation_" PKG=route53profiles
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/route53profiles/... -v -count 1 -parallel 20  -run=TestAccRoute53ProfilesResourceAssociation_ -timeout 360m
=== RUN   TestAccRoute53ProfilesResourceAssociation_basic
=== PAUSE TestAccRoute53ProfilesResourceAssociation_basic
=== RUN   TestAccRoute53ProfilesResourceAssociation_firewallRuleGroup
=== PAUSE TestAccRoute53ProfilesResourceAssociation_firewallRuleGroup
=== RUN   TestAccRoute53ProfilesResourceAssociation_resolverRule
=== PAUSE TestAccRoute53ProfilesResourceAssociation_resolverRule
=== RUN   TestAccRoute53ProfilesResourceAssociation_disappears
=== PAUSE TestAccRoute53ProfilesResourceAssociation_disappears
=== CONT  TestAccRoute53ProfilesResourceAssociation_basic
=== CONT  TestAccRoute53ProfilesResourceAssociation_resolverRule
=== CONT  TestAccRoute53ProfilesResourceAssociation_disappears
=== CONT  TestAccRoute53ProfilesResourceAssociation_firewallRuleGroup
--- PASS: TestAccRoute53ProfilesResourceAssociation_firewallRuleGroup (126.43s)
--- PASS: TestAccRoute53ProfilesResourceAssociation_resolverRule (158.75s)
--- PASS: TestAccRoute53ProfilesResourceAssociation_basic (399.76s)
--- PASS: TestAccRoute53ProfilesResourceAssociation_disappears (403.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    410.278s

> make testacc TESTARGS="-run=TestAccRoute53ProfilesProfilesDataSource_" PKG=route53profiles
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/route53profiles/... -v -count 1 -parallel 20  -run=TestAccRoute53ProfilesProfilesDataSource_ -timeout 360m
=== RUN   TestAccRoute53ProfilesProfilesDataSource_basic
=== PAUSE TestAccRoute53ProfilesProfilesDataSource_basic
=== CONT  TestAccRoute53ProfilesProfilesDataSource_basic
--- PASS: TestAccRoute53ProfilesProfilesDataSource_basic (11.31s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    16.398s

[github-actions]

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!