[new feature] fsx ontap generation 2

[awsaxeman]

Description

This is an update to support generation 2 file systems for Amazon FSx for NetApp ONTAP.

Relations

Closes #38317.

References

https://aws.amazon.com/about-aws/whats-new/2024/07/amazon-fsx-for-netapp-ontap-file-systems/

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccFSxONTAPFileSystem_haPair_increase' PKG_NAME=internal/service/fsx ACCTEST_PARALLELISM=1
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/fsx/... -v -count 1 -parallel 1  -run=TestAccFSxONTAPFileSystem_haPair_increase -timeout 360m
=== RUN   TestAccFSxONTAPFileSystem_haPair_increase
=== PAUSE TestAccFSxONTAPFileSystem_haPair_increase
=== CONT  TestAccFSxONTAPFileSystem_haPair_increase
--- PASS: TestAccFSxONTAPFileSystem_haPair_increase (3004.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        3023.896s


make testacc TESTARGS='-run=TestAccFSxONTAPFileSystem_throughputCapacity_singleAZ1' PKG_NAME=internal/service/fsx ACCTEST_PARALLELISM=1
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/fsx/... -v -count 1 -parallel 1  -run=TestAccFSxONTAPFileSystem_throughputCapacity_singleAZ1 -timeout 360m
=== RUN   TestAccFSxONTAPFileSystem_throughputCapacity_singleAZ1
=== PAUSE TestAccFSxONTAPFileSystem_throughputCapacity_singleAZ1
=== CONT  TestAccFSxONTAPFileSystem_throughputCapacity_singleAZ1
--- PASS: TestAccFSxONTAPFileSystem_throughputCapacity_singleAZ1 (5276.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        5298.219s

make testacc TESTARGS='-run=TestAccFSxONTAPFileSystem_throughputCapacity_multiAZ1' PKG_NAME=internal/service/fsx ACCTEST_PARALLEL
ISM=1
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/fsx/... -v -count 1 -parallel 1  -run=TestAccFSxONTAPFileSystem_throughputCapacity_multiAZ1 -timeout 360m
=== RUN   TestAccFSxONTAPFileSystem_throughputCapacity_multiAZ1
=== PAUSE TestAccFSxONTAPFileSystem_throughputCapacity_multiAZ1
=== CONT  TestAccFSxONTAPFileSystem_throughputCapacity_multiAZ1
--- PASS: TestAccFSxONTAPFileSystem_throughputCapacity_multiAZ1 (5560.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        5577.227s


make testacc TESTARGS='-run=TestAccFSxONTAPFileSystem_multiAZ2' PKG_NAME=internal/service/fsx ACCTEST_PARALLELISM=1
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/fsx/... -v -count 1 -parallel 1  -run=TestAccFSxONTAPFileSystem_multiAZ2 -timeout 360m
=== RUN   TestAccFSxONTAPFileSystem_multiAZ2
=== PAUSE TestAccFSxONTAPFileSystem_multiAZ2
=== CONT  TestAccFSxONTAPFileSystem_multiAZ2
--- PASS: TestAccFSxONTAPFileSystem_multiAZ2 (2960.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        2974.195s


...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxONTAPFileSystem_' PKG=fsx ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/fsx/... -v -count 1 -parallel 3  -run=TestAccFSxONTAPFileSystem_ -timeout 720m
=== RUN   TestAccFSxONTAPFileSystem_basic
=== PAUSE TestAccFSxONTAPFileSystem_basic
=== RUN   TestAccFSxONTAPFileSystem_singleAZ
=== PAUSE TestAccFSxONTAPFileSystem_singleAZ
=== RUN   TestAccFSxONTAPFileSystem_multiAZ2
=== PAUSE TestAccFSxONTAPFileSystem_multiAZ2
=== RUN   TestAccFSxONTAPFileSystem_haPair
=== PAUSE TestAccFSxONTAPFileSystem_haPair
=== RUN   TestAccFSxONTAPFileSystem_haPair_increase
=== PAUSE TestAccFSxONTAPFileSystem_haPair_increase
=== RUN   TestAccFSxONTAPFileSystem_fsxAdminPassword
=== PAUSE TestAccFSxONTAPFileSystem_fsxAdminPassword
=== RUN   TestAccFSxONTAPFileSystem_endpointIPAddressRange
=== PAUSE TestAccFSxONTAPFileSystem_endpointIPAddressRange
=== RUN   TestAccFSxONTAPFileSystem_diskIOPS
=== PAUSE TestAccFSxONTAPFileSystem_diskIOPS
=== RUN   TestAccFSxONTAPFileSystem_disappears
=== PAUSE TestAccFSxONTAPFileSystem_disappears
=== RUN   TestAccFSxONTAPFileSystem_securityGroupIDs
=== PAUSE TestAccFSxONTAPFileSystem_securityGroupIDs
=== RUN   TestAccFSxONTAPFileSystem_routeTableIDs
=== PAUSE TestAccFSxONTAPFileSystem_routeTableIDs
=== RUN   TestAccFSxONTAPFileSystem_tags
=== PAUSE TestAccFSxONTAPFileSystem_tags
=== RUN   TestAccFSxONTAPFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccFSxONTAPFileSystem_weeklyMaintenanceStartTime
=== RUN   TestAccFSxONTAPFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccFSxONTAPFileSystem_automaticBackupRetentionDays
=== RUN   TestAccFSxONTAPFileSystem_kmsKeyID
=== PAUSE TestAccFSxONTAPFileSystem_kmsKeyID
=== RUN   TestAccFSxONTAPFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccFSxONTAPFileSystem_dailyAutomaticBackupStartTime
=== RUN   TestAccFSxONTAPFileSystem_throughputCapacity
=== PAUSE TestAccFSxONTAPFileSystem_throughputCapacity
=== RUN   TestAccFSxONTAPFileSystem_throughputCapacity_singleAZ1
=== PAUSE TestAccFSxONTAPFileSystem_throughputCapacity_singleAZ1
=== RUN   TestAccFSxONTAPFileSystem_throughputCapacity_multiAZ1
=== PAUSE TestAccFSxONTAPFileSystem_throughputCapacity_multiAZ1
=== RUN   TestAccFSxONTAPFileSystem_storageCapacity
=== PAUSE TestAccFSxONTAPFileSystem_storageCapacity
=== CONT  TestAccFSxONTAPFileSystem_basic
=== CONT  TestAccFSxONTAPFileSystem_fsxAdminPassword
=== CONT  TestAccFSxONTAPFileSystem_routeTableIDs
--- PASS: TestAccFSxONTAPFileSystem_basic (2348.80s)
=== CONT  TestAccFSxONTAPFileSystem_storageCapacity
--- PASS: TestAccFSxONTAPFileSystem_fsxAdminPassword (2316.72s)
=== CONT  TestAccFSxONTAPFileSystem_throughputCapacity_multiAZ1
--- PASS: TestAccFSxONTAPFileSystem_routeTableIDs (2831.48s)
=== CONT  TestAccFSxONTAPFileSystem_throughputCapacity_singleAZ1
--- PASS: TestAccFSxONTAPFileSystem_storageCapacity (3061.72s)
=== CONT  TestAccFSxONTAPFileSystem_throughputCapacity
--- PASS: TestAccFSxONTAPFileSystem_throughputCapacity_singleAZ1 (4968.19s)
=== CONT  TestAccFSxONTAPFileSystem_dailyAutomaticBackupStartTime
--- PASS: TestAccFSxONTAPFileSystem_throughputCapacity_multiAZ1 (5370.50s)
=== CONT  TestAccFSxONTAPFileSystem_kmsKeyID
--- PASS: TestAccFSxONTAPFileSystem_throughputCapacity (3242.97s)
=== CONT  TestAccFSxONTAPFileSystem_automaticBackupRetentionDays
--- PASS: TestAccFSxONTAPFileSystem_kmsKeyID (2593.33s)
=== CONT  TestAccFSxONTAPFileSystem_weeklyMaintenanceStartTime
--- PASS: TestAccFSxONTAPFileSystem_dailyAutomaticBackupStartTime (2724.25s)
=== CONT  TestAccFSxONTAPFileSystem_tags
--- PASS: TestAccFSxONTAPFileSystem_automaticBackupRetentionDays (2889.80s)
=== CONT  TestAccFSxONTAPFileSystem_securityGroupIDs
--- PASS: TestAccFSxONTAPFileSystem_weeklyMaintenanceStartTime (2815.94s)
=== CONT  TestAccFSxONTAPFileSystem_haPair
--- PASS: TestAccFSxONTAPFileSystem_tags (2845.68s)
=== CONT  TestAccFSxONTAPFileSystem_haPair_increase
--- PASS: TestAccFSxONTAPFileSystem_haPair_increase (3432.18s)
=== CONT  TestAccFSxONTAPFileSystem_diskIOPS
--- PASS: TestAccFSxONTAPFileSystem_securityGroupIDs (5392.74s)
=== CONT  TestAccFSxONTAPFileSystem_multiAZ2
--- PASS: TestAccFSxONTAPFileSystem_haPair (4775.81s)
=== CONT  TestAccFSxONTAPFileSystem_endpointIPAddressRange
--- PASS: TestAccFSxONTAPFileSystem_diskIOPS (2939.75s)
=== CONT  TestAccFSxONTAPFileSystem_singleAZ
--- PASS: TestAccFSxONTAPFileSystem_multiAZ2 (2945.59s)
=== CONT  TestAccFSxONTAPFileSystem_disappears
--- PASS: TestAccFSxONTAPFileSystem_endpointIPAddressRange (2506.92s)
--- PASS: TestAccFSxONTAPFileSystem_singleAZ (2271.14s)
--- PASS: TestAccFSxONTAPFileSystem_disappears (2730.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	22750.651s

[ewbankkit]

@awsaxeman Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.