Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add tags support to aws_cur_report_definition resource and data source #38483

Merged
merged 1 commit into from
Jul 23, 2024
Merged

feat: Add tags support to aws_cur_report_definition resource and data source #38483

merged 1 commit into from
Jul 23, 2024

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jul 23, 2024

Description

This PR is to add tags support to the aws_cur_report_definition resource and data source.

Relations

Closes #37749

References

Referred to AWS Cost and Usage Report for specs.

Output from Acceptance Testing

$ make testacc TESTS=TestAccCUR_serial PKG=cur
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/cur/... -v -count 1 -parallel 20 -run='TestAccCUR_serial'  -timeout 360m
=== RUN   TestAccCUR_serial
=== PAUSE TestAccCUR_serial
=== CONT  TestAccCUR_serial
=== RUN   TestAccCUR_serial/ReportDefinition
=== RUN   TestAccCUR_serial/ReportDefinition/parquet
=== RUN   TestAccCUR_serial/ReportDefinition/athena
=== RUN   TestAccCUR_serial/ReportDefinition/DataSource_basic
=== RUN   TestAccCUR_serial/ReportDefinition/overwrite
=== RUN   TestAccCUR_serial/ReportDefinition/DataSource_additional
=== RUN   TestAccCUR_serial/ReportDefinition/basic
=== RUN   TestAccCUR_serial/ReportDefinition/tags
=== PAUSE TestAccCUR_serial/ReportDefinition/tags
=== RUN   TestAccCUR_serial/ReportDefinition/disappears
=== RUN   TestAccCUR_serial/ReportDefinition/textOrCsv
=== RUN   TestAccCUR_serial/ReportDefinition/refresh
=== CONT  TestAccCUR_serial/ReportDefinition/tags
--- PASS: TestAccCUR_serial (294.13s)
    --- PASS: TestAccCUR_serial/ReportDefinition (244.24s)
        --- PASS: TestAccCUR_serial/ReportDefinition/parquet (27.49s)
        --- PASS: TestAccCUR_serial/ReportDefinition/athena (26.16s)
        --- PASS: TestAccCUR_serial/ReportDefinition/DataSource_basic (24.43s)
        --- PASS: TestAccCUR_serial/ReportDefinition/overwrite (26.43s)
        --- PASS: TestAccCUR_serial/ReportDefinition/DataSource_additional (23.97s)
        --- PASS: TestAccCUR_serial/ReportDefinition/basic (38.95s)
        --- PASS: TestAccCUR_serial/ReportDefinition/disappears (24.54s)
        --- PASS: TestAccCUR_serial/ReportDefinition/textOrCsv (26.21s)
        --- PASS: TestAccCUR_serial/ReportDefinition/refresh (26.06s)
        --- PASS: TestAccCUR_serial/ReportDefinition/tags (49.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cur        294.355s

$

@acwwat acwwat requested a review from a team as a code owner July 23, 2024 04:59
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/cur Issues and PRs that pertain to the cur service. size/XL Managed by automation to categorize the size of a PR. labels Jul 23, 2024
@acwwat acwwat force-pushed the f-aws_cur_report_defintion-add_tags_support branch 2 times, most recently from b839ab0 to cef1cad Compare July 23, 2024 05:05
@acwwat acwwat force-pushed the f-aws_cur_report_defintion-add_tags_support branch from cef1cad to 13091b1 Compare July 23, 2024 05:19
jar-b
jar-b approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=cur TESTS=TestAccCUR_serial
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/cur/... -v -count 1 -parallel 20 -run='TestAccCUR_serial'  -timeout 360m
=== RUN   TestAccCUR_serial
=== PAUSE TestAccCUR_serial
=== CONT  TestAccCUR_serial
=== RUN   TestAccCUR_serial/ReportDefinition
=== RUN   TestAccCUR_serial/ReportDefinition/tags
=== PAUSE TestAccCUR_serial/ReportDefinition/tags
=== RUN   TestAccCUR_serial/ReportDefinition/parquet
=== RUN   TestAccCUR_serial/ReportDefinition/overwrite
=== RUN   TestAccCUR_serial/ReportDefinition/DataSource_additional
=== RUN   TestAccCUR_serial/ReportDefinition/basic
=== RUN   TestAccCUR_serial/ReportDefinition/disappears
=== RUN   TestAccCUR_serial/ReportDefinition/textOrCsv
=== RUN   TestAccCUR_serial/ReportDefinition/athena
=== RUN   TestAccCUR_serial/ReportDefinition/refresh
=== RUN   TestAccCUR_serial/ReportDefinition/DataSource_basic
=== CONT  TestAccCUR_serial/ReportDefinition/tags
--- PASS: TestAccCUR_serial (245.82s)
    --- PASS: TestAccCUR_serial/ReportDefinition (204.34s)
        --- PASS: TestAccCUR_serial/ReportDefinition/parquet (22.76s)
        --- PASS: TestAccCUR_serial/ReportDefinition/overwrite (21.70s)
        --- PASS: TestAccCUR_serial/ReportDefinition/DataSource_additional (20.24s)
        --- PASS: TestAccCUR_serial/ReportDefinition/basic (32.37s)
        --- PASS: TestAccCUR_serial/ReportDefinition/disappears (20.59s)
        --- PASS: TestAccCUR_serial/ReportDefinition/textOrCsv (22.05s)
        --- PASS: TestAccCUR_serial/ReportDefinition/athena (22.22s)
        --- PASS: TestAccCUR_serial/ReportDefinition/refresh (22.09s)
        --- PASS: TestAccCUR_serial/ReportDefinition/DataSource_basic (20.31s)
        --- PASS: TestAccCUR_serial/ReportDefinition/tags (41.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cur        251.649s

@jar-b
Copy link
Member

jar-b commented Jul 23, 2024

Thanks for your contribution, @acwwat! 👍

@jar-b jar-b merged commit ae2b612 into hashicorp:main Jul 23, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.60.0 milestone Jul 23, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the f-aws_cur_report_defintion-add_tags_support branch July 27, 2024 02:09
@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/cur Issues and PRs that pertain to the cur service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.60.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add tags to aws_cur_report_definition resource and data source
3 participants
@acwwat @jar-b @justinretzolk