Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Change TF behavior to complete operation of create / update RDS Clusters and Instances faster #38497

Closed
pthawley opened this issue Jul 23, 2024 · 4 comments · Fixed by #39691
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@pthawley
Copy link

Description

When creating or adding new clusters or database instances in RDS and Aurora. the instance is available for use during the "Storage-optimization" phase. See the public AWS documentation here and the AWS Knowledge Center article here.

Therefore, the TF operations that create or modify these resources should complete when the target state is either "Available" or "Storage-optimization".

Today, in there cases where the "Storage-optimization" phase is taking a long time, one of several possibilities could occur. Either the operation takes significantly more time than is actually needed or, in some extreme cases, it is possible that operation times out and fails. Neither is a good experience.

I am not really familiar with Terraform or the AWS Provider code but in looking at the wait.go file here, both the waitDBClusterInstanceCreated and waitDBClusterInstanceUpdated functions both view InstanceStatusStorageOptimization as a "Pending" state.

I was originally going to call this a bug and not an enhancement request but I don't have all of the information to create a reproducible test case. In the interest of getting this into the system faster, as well as the recognition that the existing code has been in place for a long time, please consider this hopefully small change.

Affected Resource(s) and/or Data Source(s)

Resource: aws_rds_cluster
Resource: aws_rds_cluster_instance

Potential Terraform Configuration

No response

References

See the public AWS documentation here and the AWS Knowledge Center article here.

Would you like to implement a fix?

None

@pthawley pthawley added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 23, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 23, 2024
@pthawley pthawley changed the title [Enhancement]: Change TF behavior to complete operation of create [Enhancement]: Change TF behavior to complete operation of create / update RDS Clusters and Instances faster Jul 23, 2024
@justinretzolk justinretzolk added service/rds Issues and PRs that pertain to the rds service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 24, 2024
@ewbankkit
Copy link
Contributor

ewbankkit commented Oct 11, 2024

Relates #6455.
Relates #21900.
The equivalent change for aws_db_instance was done (accidentally maybe, but no reported issues) in 763e52f.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.72.0 milestone Oct 15, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
3 participants