Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: DataZone Environment Profile #38581

Merged
merged 38 commits into from
Aug 12, 2024

Conversation

ThomasZalewski
Copy link
Contributor

Description

This resource will allow practitioners to create DataZone Environment Profiles for a DataZone Domain via Terraform.

Relations

Relates #37423

References

https://docs.aws.amazon.com/datazone/latest/APIReference/API_CreateEnvironmentProfile.html

Output from Acceptance Testing

% make testacc TESTS=TestAccDataZoneEnvironmentProfile PKG=datazone
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/datazone/... -v -count 1 -parallel 20 -run='TestAccDataZoneEnvironmentProfile'  -timeout 360m
=== RUN   TestAccDataZoneEnvironmentProfile_basic
=== PAUSE TestAccDataZoneEnvironmentProfile_basic
=== RUN   TestAccDataZoneEnvironmentProfile_disappears
=== PAUSE TestAccDataZoneEnvironmentProfile_disappears
=== CONT  TestAccDataZoneEnvironmentProfile_basic
=== CONT  TestAccDataZoneEnvironmentProfile_disappears
--- PASS: TestAccDataZoneEnvironmentProfile_disappears (28.81s)
--- PASS: TestAccDataZoneEnvironmentProfile_basic (40.73s)
PASS
...

@ThomasZalewski ThomasZalewski requested a review from a team as a code owner July 29, 2024 16:37
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/datazone Issues and PRs that pertain to the datazone service. size/XL Managed by automation to categorize the size of a PR. labels Jul 29, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍 . Just a few suggestions around naming and data handling standards.

internal/service/datazone/environment_profile.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile_test.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile_test.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile_test.go Outdated Show resolved Hide resolved
website/docs/r/datazone_environment_profile.html.markdown Outdated Show resolved Hide resolved
website/docs/r/datazone_environment_profile.html.markdown Outdated Show resolved Hide resolved
@ThomasZalewski ThomasZalewski changed the title [New Resource]: DataZone Enviroment Profile [New Resource]: DataZone Environment Profile Jul 30, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few suggestions on AutoFlex options and clarifying the import logic and documentation.

.changelog/35603.txt Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile_test.go Outdated Show resolved Hide resolved
website/docs/r/datazone_environment_profile.html.markdown Outdated Show resolved Hide resolved
website/docs/r/datazone_environment_profile.html.markdown Outdated Show resolved Hide resolved
website/docs/r/datazone_environment_profile.html.markdown Outdated Show resolved Hide resolved
website/docs/r/datazone_environment_profile.html.markdown Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile.go Outdated Show resolved Hide resolved
internal/service/datazone/environment_profile.go Outdated Show resolved Hide resolved
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=datazone TESTS=TestAccDataZoneEnvironmentProfile_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/datazone/... -v -count 1 -parallel 20 -run='TestAccDataZoneEnvironmentProfile_'  -timeout 360m

--- PASS: TestAccDataZoneEnvironmentProfile_disappears (30.12s)
--- PASS: TestAccDataZoneEnvironmentProfile_basic (32.06s)
--- PASS: TestAccDataZoneEnvironmentProfile_update (46.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datazone   52.788s

@jar-b jar-b merged commit a7d7bba into main Aug 12, 2024
42 checks passed
@jar-b jar-b deleted the f/datazone-enviroment-profile-resource branch August 12, 2024 20:04
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 12, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/datazone Issues and PRs that pertain to the datazone service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants