Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_iot_thing_group: fix crash with empty attribute_payload block #38776

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 8, 2024

Description

Setting the attribute_payload argument to an empty block resulted the in the associated expander attempting to assert the lists single nil item into a map. This change adds a check for nil items to prevent this.

Relations

Closes #38093

Output from Acceptance Testing

% make testacc PKG=iot TESTS=TestAccIoTThingGroup_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTThingGroup_'  -timeout 360m

--- PASS: TestAccIoTThingGroup_disappears (12.93s)
--- PASS: TestAccIoTThingGroup_basic (15.24s)
--- PASS: TestAccIoTThingGroup_parentGroup (19.73s)
--- PASS: TestAccIoTThingGroup_properties (22.78s)
--- PASS: TestAccIoTThingGroup_tags (30.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        36.178s

Copy link

github-actions bot commented Aug 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/iot Issues and PRs that pertain to the iot service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 8, 2024
Setting the `attribute_payload` argument to an empty block resulted the in the associated expander attempting to assert the lists single nil item into a map. This change adds a check for nil items to prevent this.

```console
% make testacc PKG=iot TESTS=TestAccIoTThingGroup_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTThingGroup_'  -timeout 360m

--- PASS: TestAccIoTThingGroup_disappears (12.93s)
--- PASS: TestAccIoTThingGroup_basic (15.24s)
--- PASS: TestAccIoTThingGroup_parentGroup (19.73s)
--- PASS: TestAccIoTThingGroup_properties (22.78s)
--- PASS: TestAccIoTThingGroup_tags (30.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        36.178s
```
@jar-b jar-b added crash Results from or addresses a Terraform crash or kernel panic. bug Addresses a defect in current functionality. labels Aug 8, 2024
@jar-b jar-b marked this pull request as ready for review August 8, 2024 20:04
@jar-b jar-b requested a review from a team as a code owner August 8, 2024 20:04
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 182ff94 into main Aug 12, 2024
52 checks passed
@jar-b jar-b deleted the b-iot-thing-group-panic branch August 12, 2024 19:16
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 12, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/iot Issues and PRs that pertain to the iot service.
Projects
None yet
2 participants