Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_cognito_user_pool.password_policy.Allow_reuse_of_previous_passwords #39016

Closed
SuperP4rks opened this issue Aug 23, 2024 · 5 comments · Fixed by #39043
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cognitoidp Issues and PRs that pertain to the cognitoidp service.
Milestone

Comments

@SuperP4rks
Copy link

Description

Request for Allow_reuse_of_previous_passwords to be added to the password_policy in aws_cognito_user_pool resource.

This is a new feature released in Cognito and would make sense to enhance the password_policy as thats where it sits within the UI experience, however there is a requirement for the advanced security to be active.

Affected Resource(s) and/or Data Source(s)

aws_cognito_user_pool

Potential Terraform Configuration

resource "aws_cognito_user_pool" "this" {
  password_policy {
    minimum_length                   = "10"
    require_lowercase                = "true"
    require_numbers                  = "true"
    require_symbols                  = "true"
    require_uppercase                = "true"
    temporary_password_validity_days = "10"
    Allow_reuse_of_previous_passwords = "true"
  }
}

References

No response

Would you like to implement a fix?

No

@SuperP4rks SuperP4rks added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 23, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/cognitoidp Issues and PRs that pertain to the cognitoidp service. label Aug 23, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 23, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 26, 2024
@DizzyDeveloper
Copy link

I want to second this issue, with a slight addendum:

resource "aws_cognito_user_pool" "this" {
  password_policy {
    minimum_length                   = "10"
    require_lowercase                = "true"
    require_numbers                  = "true"
    require_symbols                  = "true"
    require_uppercase                = "true"
    temporary_password_validity_days = "10"

    password_history_size = 2 /* Instead of aforementioned Allow_reuse_of_previous_passwords */
  
  }
}

At the moment this can be achieved by using exec local and manually invoking the the aws cli aws cognito-idp update-user-pool however if miss configure the cli call it will overwrite what was configured as part of the original aws_cognito_user_pool declaration which is not optimal.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.65.0 milestone Aug 27, 2024
Copy link

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cognitoidp Issues and PRs that pertain to the cognitoidp service.
Projects
None yet
3 participants