Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: [New Data Source]: AWS Organizations descendant OUs #39120

Merged

Conversation

jordanst3wart
Copy link

@jordanst3wart jordanst3wart commented Sep 3, 2024

Description

Implements a new data source for aws organization unit descendants

Relations

Closes: #30992

References

Current data source only includes immediate children:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/organizations_organizational_units

Output from Acceptance Testing

% make testacc TESTS=TestAccOrganizations_serial PKG=organizations
# fails with environment variables not set

@jordanst3wart jordanst3wart requested a review from a team as a code owner September 3, 2024 13:38
Copy link

github-actions bot commented Sep 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/organizations Issues and PRs that pertain to the organizations service. generators Relates to code generators. labels Sep 3, 2024
@jordanst3wart jordanst3wart changed the title feature: [New Data Source]: AWS Organizations descendant OUs (issue #… feature: [New Data Source]: AWS Organizations descendant OUs Sep 3, 2024
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 3, 2024
@jordanst3wart
Copy link
Author

jordanst3wart commented Sep 3, 2024

I may need to look more into testing

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jordanst3wart 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 3, 2024
@ewbankkit ewbankkit self-assigned this Sep 3, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 3, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOrganizations_serial/OrganizationalUnit/DescendantOUsDataSource_basic' PKG=organizations
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/organizations/... -v -count 1 -parallel 20  -run=TestAccOrganizations_serial/OrganizationalUnit/DescendantOUsDataSource_basic -timeout 360m
=== RUN   TestAccOrganizations_serial
=== PAUSE TestAccOrganizations_serial
=== CONT  TestAccOrganizations_serial
=== RUN   TestAccOrganizations_serial/OrganizationalUnit
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/DescendantOUsDataSource_basic
--- PASS: TestAccOrganizations_serial (16.82s)
    --- PASS: TestAccOrganizations_serial/OrganizationalUnit (16.82s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/DescendantOUsDataSource_basic (16.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/organizations	21.651s

@ewbankkit
Copy link
Contributor

@jordanst3wart Thanks for the contribution 🎉 👏.
I renamed to aws_organizations_organizational_unit_descendant_organizational_units.

@ewbankkit ewbankkit merged commit 1046c82 into hashicorp:main Sep 3, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.66.0 milestone Sep 3, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Oct 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/organizations Issues and PRs that pertain to the organizations service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Resource]: AWS Organizations child OUs
2 participants