Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_quicksight_data_set: Change permissions.actions MaxItems from 16 to 20 #39226

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 9, 2024

Description

Fixes v5.66.0 regression.

Relations

Closes #39219.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccQuickSightDataSet_' PKG=quicksight ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/quicksight/... -v -count 1 -parallel 3  -run=TestAccQuickSightDataSet_ -timeout 360m
=== RUN   TestAccQuickSightDataSet_basic
=== PAUSE TestAccQuickSightDataSet_basic
=== RUN   TestAccQuickSightDataSet_disappears
=== PAUSE TestAccQuickSightDataSet_disappears
=== RUN   TestAccQuickSightDataSet_columnGroups
=== PAUSE TestAccQuickSightDataSet_columnGroups
=== RUN   TestAccQuickSightDataSet_columnLevelPermissionRules
=== PAUSE TestAccQuickSightDataSet_columnLevelPermissionRules
=== RUN   TestAccQuickSightDataSet_dataSetUsageConfiguration
=== PAUSE TestAccQuickSightDataSet_dataSetUsageConfiguration
=== RUN   TestAccQuickSightDataSet_fieldFolders
=== PAUSE TestAccQuickSightDataSet_fieldFolders
=== RUN   TestAccQuickSightDataSet_logicalTableMap
=== PAUSE TestAccQuickSightDataSet_logicalTableMap
=== RUN   TestAccQuickSightDataSet_permissions
=== PAUSE TestAccQuickSightDataSet_permissions
=== RUN   TestAccQuickSightDataSet_permissionsMultiple
=== PAUSE TestAccQuickSightDataSet_permissionsMultiple
=== RUN   TestAccQuickSightDataSet_rowLevelPermissionTagConfiguration
=== PAUSE TestAccQuickSightDataSet_rowLevelPermissionTagConfiguration
=== RUN   TestAccQuickSightDataSet_refreshProperties
    data_set_test.go:414: Environment variable QUICKSIGHT_ATHENA_TESTING_ENABLED is not set
--- SKIP: TestAccQuickSightDataSet_refreshProperties (0.00s)
=== RUN   TestAccQuickSightDataSet_tags
=== PAUSE TestAccQuickSightDataSet_tags
=== RUN   TestAccQuickSightDataSet_noPhysicalTableMap
=== PAUSE TestAccQuickSightDataSet_noPhysicalTableMap
=== CONT  TestAccQuickSightDataSet_basic
=== CONT  TestAccQuickSightDataSet_logicalTableMap
=== CONT  TestAccQuickSightDataSet_columnLevelPermissionRules
--- PASS: TestAccQuickSightDataSet_columnLevelPermissionRules (33.88s)
=== CONT  TestAccQuickSightDataSet_rowLevelPermissionTagConfiguration
--- PASS: TestAccQuickSightDataSet_basic (36.45s)
=== CONT  TestAccQuickSightDataSet_noPhysicalTableMap
--- PASS: TestAccQuickSightDataSet_logicalTableMap (61.38s)
=== CONT  TestAccQuickSightDataSet_tags
--- PASS: TestAccQuickSightDataSet_rowLevelPermissionTagConfiguration (32.44s)
=== CONT  TestAccQuickSightDataSet_columnGroups
--- PASS: TestAccQuickSightDataSet_noPhysicalTableMap (38.27s)
=== CONT  TestAccQuickSightDataSet_permissionsMultiple
--- PASS: TestAccQuickSightDataSet_columnGroups (32.71s)
=== CONT  TestAccQuickSightDataSet_fieldFolders
--- PASS: TestAccQuickSightDataSet_permissionsMultiple (33.49s)
=== CONT  TestAccQuickSightDataSet_disappears
--- PASS: TestAccQuickSightDataSet_fieldFolders (32.88s)
=== CONT  TestAccQuickSightDataSet_permissions
--- PASS: TestAccQuickSightDataSet_tags (72.46s)
=== CONT  TestAccQuickSightDataSet_dataSetUsageConfiguration
--- PASS: TestAccQuickSightDataSet_disappears (28.06s)
--- PASS: TestAccQuickSightDataSet_dataSetUsageConfiguration (32.77s)
--- PASS: TestAccQuickSightDataSet_permissions (83.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	221.562s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema	0.855s [no tests to run]

@ewbankkit ewbankkit requested a review from a team as a code owner September 9, 2024 16:03
Copy link

github-actions bot commented Sep 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/quicksight Issues and PRs that pertain to the quicksight service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 9, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@travwarren
Copy link

It looks like the maxItems should be 64 per the APIs docs: https://docs.aws.amazon.com/quicksight/latest/APIReference/API_UpdateDataSetPermissions.html

@ewbankkit ewbankkit merged commit 96eeeab into main Sep 9, 2024
31 checks passed
@ewbankkit ewbankkit deleted the issue-39219 branch September 9, 2024 18:06
@github-actions github-actions bot added this to the v5.67.0 milestone Sep 9, 2024
@chammock
Copy link
Contributor

chammock commented Sep 9, 2024

It looks like the maxItems should be 64 per the APIs docs: https://docs.aws.amazon.com/quicksight/latest/APIReference/API_UpdateDataSetPermissions.html

The UpdateDataSetPermissions.GrantPermissions or UpdateDataSetPermissions.RevokePermissions can take 64 ResourcePermission objects. However, the ResourcePermission.Actions object can only be 20 items.

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_ResourcePermission.html

@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Sep 9, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 9, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Insufficient QuickSight dataset permissions
4 participants