Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: AppSync GraphQL Source Api Association #39323

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Sep 13, 2024

Description

Add resource to associate APIs to a MERGED type API.

Relations

Closes #33148

References

Output from Acceptance Testing

%  make testacc TESTS=TestAccAppSync_serial/SourceApiAssociation PKG=appsync
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/appsync/... -v -count 1 -parallel 20 -run='TestAccAppSync_serial/SourceApiAssociation'  -timeout 360m
=== RUN   TestAccAppSync_serial
=== PAUSE TestAccAppSync_serial
=== CONT  TestAccAppSync_serial
=== RUN   TestAccAppSync_serial/SourceApiAssociation
=== RUN   TestAccAppSync_serial/SourceApiAssociation/disappears
=== PAUSE TestAccAppSync_serial/SourceApiAssociation/disappears
=== RUN   TestAccAppSync_serial/SourceApiAssociation/update
=== PAUSE TestAccAppSync_serial/SourceApiAssociation/update
=== RUN   TestAccAppSync_serial/SourceApiAssociation/basic
=== PAUSE TestAccAppSync_serial/SourceApiAssociation/basic
=== CONT  TestAccAppSync_serial/SourceApiAssociation/disappears
=== CONT  TestAccAppSync_serial/SourceApiAssociation/update
=== CONT  TestAccAppSync_serial/SourceApiAssociation/basic
--- PASS: TestAccAppSync_serial (45.31s)
    --- PASS: TestAccAppSync_serial/SourceApiAssociation (0.00s)
        --- PASS: TestAccAppSync_serial/SourceApiAssociation/disappears (27.12s)
        --- PASS: TestAccAppSync_serial/SourceApiAssociation/basic (34.50s)
        --- PASS: TestAccAppSync_serial/SourceApiAssociation/update (45.31s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appsync    50.140s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appsync Issues and PRs that pertain to the appsync service. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Sep 13, 2024
@drewtul drewtul force-pushed the f-appsync-source-api-assoc branch 3 times, most recently from dd434d4 to 17e1275 Compare September 16, 2024 08:15
@drewtul drewtul marked this pull request as ready for review September 16, 2024 11:50
@drewtul drewtul requested a review from a team as a code owner September 16, 2024 11:50
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2024
@ewbankkit ewbankkit self-assigned this Sep 17, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 17, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppSync_serial/SourceApiAssociation' PKG=appsync
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/appsync/... -v -count 1 -parallel 20  -run=TestAccAppSync_serial/SourceApiAssociation -timeout 360m
=== RUN   TestAccAppSync_serial
=== PAUSE TestAccAppSync_serial
=== CONT  TestAccAppSync_serial
=== RUN   TestAccAppSync_serial/SourceApiAssociation
=== RUN   TestAccAppSync_serial/SourceApiAssociation/basic
=== PAUSE TestAccAppSync_serial/SourceApiAssociation/basic
=== RUN   TestAccAppSync_serial/SourceApiAssociation/disappears
=== PAUSE TestAccAppSync_serial/SourceApiAssociation/disappears
=== RUN   TestAccAppSync_serial/SourceApiAssociation/update
=== PAUSE TestAccAppSync_serial/SourceApiAssociation/update
=== CONT  TestAccAppSync_serial/SourceApiAssociation/basic
=== CONT  TestAccAppSync_serial/SourceApiAssociation/update
=== CONT  TestAccAppSync_serial/SourceApiAssociation/disappears
--- PASS: TestAccAppSync_serial (30.80s)
    --- PASS: TestAccAppSync_serial/SourceApiAssociation (0.00s)
        --- PASS: TestAccAppSync_serial/SourceApiAssociation/disappears (17.71s)
        --- PASS: TestAccAppSync_serial/SourceApiAssociation/basic (19.51s)
        --- PASS: TestAccAppSync_serial/SourceApiAssociation/update (30.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appsync	35.909s

@ewbankkit
Copy link
Contributor

@drewtul Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d0821c8 into hashicorp:main Sep 17, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.68.0 milestone Sep 17, 2024
@drewtul drewtul deleted the f-appsync-source-api-assoc branch September 17, 2024 17:59
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 20, 2024
Copy link

This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. partner Contribution from a partner. service/appsync Issues and PRs that pertain to the appsync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for AWS AppSync merged APIs
2 participants