Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: for aws_ses_receipt_rule adding argument s3_action.iam_role_arn #39332

Closed
phil-o7conseils opened this issue Sep 14, 2024 · 5 comments · Fixed by #39364
Closed
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service.
Milestone

Comments

@phil-o7conseils
Copy link

Description

When SES needs to write e-mails in a S3 bucket where encryption is required with a KMS Customer Managed Key a role must be assigned to the S3 action. The option is available in the AWS Console and in the SDK. Below is the AWS documentation about the S3 Action configuration.
https://docs.aws.amazon.com/ses/latest/APIReference/API_S3Action.html

The parameters for the s3_action for aws_ses_receipt_rule is only missing support for the parameter: IamRoleArn.
Following the convention it would be named : iam_role_arn

Affected Resource(s) and/or Data Source(s)

aws_ses_receipt_rule

Potential Terraform Configuration

resource "aws_ses_receipt_rule" "store_to_s3" {
  name          = "store-to-s3"
  rule_set_name = aws_ses_receipt_rule_set.primary_rule.id
  recipients    = ["${aws_ses_domain_identity.ses_domain.id}"]
  enabled       = true
  scan_enabled  = false

  s3_action {
    bucket_name       = aws_s3_bucket.incoming_emails.id
    object_key_prefix = "default-rule-set/"
    position          = 1
    kms_key_arn       = var.kms_key_arn
    iam_role_arn      = aws_iam_role.ses_role.arn # Missing argument
  }

  depends_on = [aws_s3_bucket_policy.write_incoming_emails]
}

References

https://docs.aws.amazon.com/ses/latest/APIReference/API_S3Action.html
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ses_receipt_rule#bucket_name

Would you like to implement a fix?

None

@phil-o7conseils phil-o7conseils added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 14, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/ses Issues and PRs that pertain to the ses service. needs-triage Waiting for first response or review from a maintainer. labels Sep 14, 2024
@kamilturek kamilturek self-assigned this Sep 15, 2024
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 16, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.68.0 milestone Sep 19, 2024
@phil-o7conseils
Copy link
Author

Wow ! this was a quick resolution of our requested enhancement.
@kamilturek : Thank you for your efforts !

Copy link

This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service.
Projects
None yet
3 participants