Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_kinesis_stream: Tag on create #39504

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 26, 2024

Description

Tag on Create for the aws_kinesis_stream resource.

Relations

Closes #39502.

Output from Acceptance Testing

AWS Standard

% make testacc TESTARGS='-run=TestAccKinesisStream_basic\|TestAccKinesisStream_tags' PKG=kinesis
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/kinesis/... -v -count 1 -parallel 20  -run=TestAccKinesisStream_basic\|TestAccKinesisStream_tags -timeout 360m
=== RUN   TestAccKinesisStream_basic
=== PAUSE TestAccKinesisStream_basic
=== RUN   TestAccKinesisStream_tags
=== PAUSE TestAccKinesisStream_tags
=== RUN   TestAccKinesisStream_basicOnDemand
=== PAUSE TestAccKinesisStream_basicOnDemand
=== CONT  TestAccKinesisStream_basic
=== CONT  TestAccKinesisStream_basicOnDemand
=== CONT  TestAccKinesisStream_tags
--- PASS: TestAccKinesisStream_basic (45.69s)
--- PASS: TestAccKinesisStream_basicOnDemand (45.96s)
--- PASS: TestAccKinesisStream_tags (62.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	67.834s

AWS US GovCloud

% make testacc TESTARGS='-run=TestAccKinesisStream_basic\|TestAccKinesisStream_tags' PKG=kinesis
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/kinesis/... -v -count 1 -parallel 20  -run=TestAccKinesisStream_basic\|TestAccKinesisStream_tags -timeout 360m
=== RUN   TestAccKinesisStream_basic
=== PAUSE TestAccKinesisStream_basic
=== RUN   TestAccKinesisStream_tags
=== PAUSE TestAccKinesisStream_tags
=== RUN   TestAccKinesisStream_basicOnDemand
=== PAUSE TestAccKinesisStream_basicOnDemand
=== CONT  TestAccKinesisStream_basic
=== CONT  TestAccKinesisStream_basicOnDemand
=== CONT  TestAccKinesisStream_tags
--- PASS: TestAccKinesisStream_basicOnDemand (45.63s)
--- PASS: TestAccKinesisStream_basic (45.73s)
--- PASS: TestAccKinesisStream_tags (62.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	67.353s

@ewbankkit ewbankkit requested a review from a team as a code owner September 26, 2024 16:09
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/kinesis Issues and PRs that pertain to the kinesis service. tags Pertains to resource tagging. generators Relates to code generators. labels Sep 26, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 26, 2024
…'tags' failed to satisfy constraint: Member must have length greater than or equal to 1'.
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=kinesis TESTS="TestAccKinesisStream_basic|TestAccKinesisStream_tags"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStream_basic|TestAccKinesisStream_tags'  -timeout 360m

--- PASS: TestAccKinesisStream_basic (47.68s)
--- PASS: TestAccKinesisStream_basicOnDemand (47.69s)
--- PASS: TestAccKinesisStream_tags (65.45s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesis    71.972s

@ewbankkit ewbankkit merged commit c8ffe25 into main Sep 26, 2024
49 of 50 checks passed
@ewbankkit ewbankkit deleted the f-r/aws_kinesis_stream-tag-on-create branch September 26, 2024 18:43
@github-actions github-actions bot added this to the v5.69.0 milestone Sep 26, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 26, 2024
Copy link

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generators Relates to code generators. service/kinesis Issues and PRs that pertain to the kinesis service. tags Pertains to resource tagging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_kinesis_stream: Tag on Create
2 participants