Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_iam_user_policies_exclusive: new resource #39544

Merged
merged 1 commit into from
Oct 2, 2024
Merged

r/aws_iam_user_policies_exclusive: new resource #39544

merged 1 commit into from
Oct 2, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Sep 30, 2024 •
edited
Loading

Description

This resource will enable exclusive management of inline policy assignments to an IAM user via Terraform.

Relations

Relates #39376
Closes #39377

Output from Acceptance Testing

% make testacc PKG=iam TESTS=TestAccIAMUserPoliciesExclusive_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMUserPoliciesExclusive_'  -timeout 360m

--- PASS: TestAccIAMUserPoliciesExclusive_empty (14.20s)
--- PASS: TestAccIAMUserPoliciesExclusive_disappears_User (14.87s)
--- PASS: TestAccIAMUserPoliciesExclusive_basic (16.78s)
--- PASS: TestAccIAMUserPoliciesExclusive_outOfBandRemoval (23.39s)
--- PASS: TestAccIAMUserPoliciesExclusive_outOfBandAddition (23.42s)
--- PASS: TestAccIAMUserPoliciesExclusive_multiple (25.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        32.023s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 30, 2024
@jar-b jar-b force-pushed the f-iam_user_policies_exclusive branch 2 times, most recently from 49aaa8c to cdf167e Compare September 30, 2024 20:26
@jar-b jar-b marked this pull request as ready for review September 30, 2024 20:27
@jar-b jar-b requested a review from a team as a code owner September 30, 2024 20:27
@jar-b
r/aws_iam_user_policies_exclusive: new resource
8106f15 
This resource will enable exclusive management of IAM user policy
attachments via Terraform.

```console
% make testacc PKG=iam TESTS=TestAccIAMUserPoliciesExclusive_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMUserPoliciesExclusive_'  -timeout 360m

--- PASS: TestAccIAMUserPoliciesExclusive_empty (14.20s)
--- PASS: TestAccIAMUserPoliciesExclusive_disappears_User (14.87s)
--- PASS: TestAccIAMUserPoliciesExclusive_basic (16.78s)
--- PASS: TestAccIAMUserPoliciesExclusive_outOfBandRemoval (23.39s)
--- PASS: TestAccIAMUserPoliciesExclusive_outOfBandAddition (23.42s)
--- PASS: TestAccIAMUserPoliciesExclusive_multiple (25.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        32.023s
```
@jar-b jar-b force-pushed the f-iam_user_policies_exclusive branch from cdf167e to 8106f15 Compare October 1, 2024 13:18
ewbankkit
ewbankkit approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIAMUserPoliciesExclusive_' PKG=iam ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/iam/... -v -count 1 -parallel 3  -run=TestAccIAMUserPoliciesExclusive_ -timeout 360m
=== RUN   TestAccIAMUserPoliciesExclusive_basic
=== PAUSE TestAccIAMUserPoliciesExclusive_basic
=== RUN   TestAccIAMUserPoliciesExclusive_disappears_User
=== PAUSE TestAccIAMUserPoliciesExclusive_disappears_User
=== RUN   TestAccIAMUserPoliciesExclusive_multiple
=== PAUSE TestAccIAMUserPoliciesExclusive_multiple
=== RUN   TestAccIAMUserPoliciesExclusive_empty
=== PAUSE TestAccIAMUserPoliciesExclusive_empty
=== RUN   TestAccIAMUserPoliciesExclusive_outOfBandRemoval
=== PAUSE TestAccIAMUserPoliciesExclusive_outOfBandRemoval
=== RUN   TestAccIAMUserPoliciesExclusive_outOfBandAddition
=== PAUSE TestAccIAMUserPoliciesExclusive_outOfBandAddition
=== CONT  TestAccIAMUserPoliciesExclusive_basic
=== CONT  TestAccIAMUserPoliciesExclusive_empty
=== CONT  TestAccIAMUserPoliciesExclusive_multiple
--- PASS: TestAccIAMUserPoliciesExclusive_empty (11.27s)
=== CONT  TestAccIAMUserPoliciesExclusive_disappears_User
--- PASS: TestAccIAMUserPoliciesExclusive_basic (13.01s)
=== CONT  TestAccIAMUserPoliciesExclusive_outOfBandAddition
--- PASS: TestAccIAMUserPoliciesExclusive_multiple (20.07s)
=== CONT  TestAccIAMUserPoliciesExclusive_outOfBandRemoval
--- PASS: TestAccIAMUserPoliciesExclusive_disappears_User (10.37s)
--- PASS: TestAccIAMUserPoliciesExclusive_outOfBandAddition (17.16s)
--- PASS: TestAccIAMUserPoliciesExclusive_outOfBandRemoval (17.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	42.732s

@jar-b jar-b merged commit 0f5786a into main Oct 2, 2024
48 checks passed
@jar-b jar-b deleted the f-iam_user_policies_exclusive branch October 2, 2024 12:58
@github-actions github-actions bot added this to the v5.70.0 milestone Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024
@jar-b jar-b mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.70.0
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_iam_user_policies_exclusive
2 participants
@jar-b @ewbankkit