Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add start_time attribute to data source aws_ebs_snapshot #39557

Merged

Conversation

stefanfreitag
Copy link
Contributor

Description

Add start time attribute to the data source.

Relations

Closes #39497

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccEC2EBSSnapshotDataSource PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/ec2/... -v -count 1 -parallel 5 -run='TestAccEC2EBSSnapshotDataSource'  -timeout 360m
=== RUN   TestAccEC2EBSSnapshotDataSource_basic
=== PAUSE TestAccEC2EBSSnapshotDataSource_basic
=== RUN   TestAccEC2EBSSnapshotDataSource_filter
=== PAUSE TestAccEC2EBSSnapshotDataSource_filter
=== RUN   TestAccEC2EBSSnapshotDataSource_mostRecent
=== PAUSE TestAccEC2EBSSnapshotDataSource_mostRecent
=== CONT  TestAccEC2EBSSnapshotDataSource_basic
=== CONT  TestAccEC2EBSSnapshotDataSource_mostRecent
=== CONT  TestAccEC2EBSSnapshotDataSource_filter
--- PASS: TestAccEC2EBSSnapshotDataSource_mostRecent (76.67s)
--- PASS: TestAccEC2EBSSnapshotDataSource_filter (87.43s)
--- PASS: TestAccEC2EBSSnapshotDataSource_basic (87.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        87.929s

Copy link

github-actions bot commented Oct 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. needs-triage Waiting for first response or review from a maintainer. labels Oct 1, 2024
@stefanfreitag stefanfreitag marked this pull request as ready for review October 2, 2024 04:07
@stefanfreitag stefanfreitag requested a review from a team as a code owner October 2, 2024 04:07
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Oct 2, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=ebs TESTS=TestAccEC2EBSSnapshotDataSource
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EBSSnapshotDataSource'  -timeout 360m

--- PASS: TestAccEC2EBSSnapshotDataSource_filter (69.73s)
--- PASS: TestAccEC2EBSSnapshotDataSource_basic (113.01s)
--- PASS: TestAccEC2EBSSnapshotDataSource_mostRecent (138.81s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        145.982s

@jar-b
Copy link
Member

jar-b commented Oct 2, 2024

Thanks for your contribution, @stefanfreitag! 👍

@jar-b jar-b merged commit 2b0ad37 into hashicorp:main Oct 2, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.70.0 milestone Oct 2, 2024
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@stefanfreitag stefanfreitag deleted the f-aws_ebs_snapshot-add-start-time branch October 8, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_ebs_snapshot data source should return StartTime
2 participants