Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying Encryption for aws_s3_bucket_object #44

Closed
hashibot opened this issue Jun 13, 2017 · 8 comments
Closed

Specifying Encryption for aws_s3_bucket_object #44

hashibot opened this issue Jun 13, 2017 · 8 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service.

Comments

@hashibot
Copy link

This issue was originally opened by @st-isidore-de-seville as hashicorp/terraform#3475. It was migrated here as part of the provider split. The original body of the issue is below.


Is there a way that encryption can be specified for aws_s3_bucket_object?

@hashibot hashibot added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 13, 2017
@hashibot
Copy link
Author

This comment was originally opened by @radeksimko as hashicorp/terraform#3475 (comment). It was migrated here as part of the provider split. The original comment is below.


Sorry I misread your original issue, this is not quite supported yet for the aws_s3_bucket_object itself.
Keeping open.

@hashibot
Copy link
Author

This comment was originally opened by @radeksimko as hashicorp/terraform#3475 (comment). It was migrated here as part of the provider split. The original comment is below.


KMS encryption support was merged as part of hashicorp/terraform#5453 and will be in the next release.

I'm keeping this open though, since encryption with customer key isn't supported yet.

@hashibot
Copy link
Author

This comment was originally opened by @jason-riddle as hashicorp/terraform#3475 (comment). It was migrated here as part of the provider split. The original comment is below.


So that lets you specify a KMS encryption key, but what about the AWS managed "AES256" option?

@hashibot
Copy link
Author

This comment was originally opened by @conorgil as hashicorp/terraform#3475 (comment). It was migrated here as part of the provider split. The original comment is below.


@st-isidore-de-seville According to the aws_s3_bucket_object docs, this capability is now supported. If you agree, perhaps you can close this issue?

@hashibot
Copy link
Author

This comment was originally opened by @radeksimko as hashicorp/terraform#3475 (comment). It was migrated here as part of the provider split. The original comment is below.


@conorgil Thanks for the ping, but we don't actually support SSE via customer provided keys yet. The related attributes seem to be SSECustomerAlgorithm, SSECustomerKey and SSECustomerKeyMD5 which we don't use anywhere (yet).

Contributions are welcomed.

@hashibot
Copy link
Author

This comment was originally opened by @conorgil as hashicorp/terraform#3475 (comment). It was migrated here as part of the provider split. The original comment is below.


@radeksimko Ah, ok. The initial issue description didn't clarify what was included feature wise and I didn't read your comment carefully until just now. Thanks for clarifying.

I am just learning go, so it might be a while before I can contribute on that level, but I'll take a crack at it down the road once I'm up to speed if no one gets to it first.

@radeksimko radeksimko added the service/s3 Issues and PRs that pertain to the s3 service. label Jan 25, 2018
@aeschright
Copy link
Contributor

Thanks for the request! Since this feature is now supported, I will close the ticket: https://www.terraform.io/docs/providers/aws/r/s3_bucket_object.html#server-side-encryption-with-aws-managed-key

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service.
Projects
None yet
Development

No branches or pull requests

3 participants