Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_autoscaling_attachment: incorrect parameter name "alb_target_group_arn" #5407

Closed
steeef opened this issue Jul 31, 2018 · 5 comments · Fixed by #30828
Closed

aws_autoscaling_attachment: incorrect parameter name "alb_target_group_arn" #5407

steeef opened this issue Jul 31, 2018 · 5 comments · Fixed by #30828
Assignees
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. proposal Proposes new design or functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@steeef
Copy link

steeef commented Jul 31, 2018

Terraform Version

❯ terraform -v
Terraform v0.11.7
+ provider.aws v1.29.0

Affected Resource(s)

  • aws_autoscaling_attachment

Terraform Configuration Files

resource "aws_autoscaling_attachment" "elasticsearch" {
  autoscaling_group_name = "${aws_autoscaling_group.elasticsearch.id}"
  alb_target_group_arn   = "${var.target_group}"
}

Debug Output

Panic Output

Expected Behavior

When attaching an NLB target group to an autoscaling group, I expected to find a parameter named lb_target_group_arn.

Actual Behavior

Parameter was named alb_target_group_arn:
https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_autoscaling_attachment.go#L33
Additionally, docs refer to an ALB target group:
https://github.com/terraform-providers/terraform-provider-aws/blob/master/website/docs/r/autoscaling_attachment.html.markdown

This seems to suggest that only an ALB target group can be attached to an autoscaling group. However it's possible to attach NLB target groups as well.

@steeef steeef changed the title aws_autoscaling_attachment: incorrect parameter name alb_target_group_arn aws_autoscaling_attachment: incorrect parameter name "alb_target_group_arn" Jul 31, 2018
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Jul 31, 2018
@jowrjowr
Copy link

jowrjowr commented Feb 5, 2020

This is still an issue. Came here to report this.

The actual label itself isn't too big of a deal but the documentation is the real nuisance. If this is documented in https://www.terraform.io/docs/providers/aws/r/autoscaling_attachment.html to specifically note it works for both ALB and NLB ARNs, it'd really help.

@bflad bflad added the proposal Proposes new design or functionality. label Jul 7, 2020
@bflad bflad added this to the v4.0.0 milestone Jul 7, 2020
@MarcClusterman
Copy link

This continues to cause confusion, it would be nice for the docs to at least explain.

@anGie44 anGie44 self-assigned this Jan 19, 2022
@anGie44 anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 19, 2022
@anGie44 anGie44 modified the milestones: v4.0.0, v5.0.0 Jan 19, 2022
@anGie44 anGie44 removed their assignment Jun 21, 2022
@YakDriver YakDriver self-assigned this Apr 19, 2023
@github-actions github-actions bot modified the milestones: v5.0.0, v4.64.0 Apr 20, 2023
@YakDriver YakDriver modified the milestones: v4.64.0, v5.0.0 Apr 20, 2023
@jar-b
Copy link
Member

jar-b commented May 23, 2023

Closed by #30828, merged to main via #31392

@jar-b jar-b closed this as completed May 23, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. proposal Proposes new design or functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants