Directory Service Shared Directory Support (SharedMicrosoftAD Directory Type)

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS recently announced support for cross-account shared Microsoft Active Directory resources: https://aws.amazon.com/about-aws/whats-new/2018/09/aws-directory-service-share-directory-across-accounts-and-vpcs/

To properly support this setup, it looks like we'll need to implement the following:

• (This feature request) Update the aws_directory_service_directory resource for type = "SharedMicrosoftAD"
• (Directory Service Shared Directory Support (Share Directory Resource) #6004) Create new resource for sharing directories
• (Directory Service Shared Directory Support (Share Directory Accepter Resource) #6005) Create new resource for accepting directory share requests

New or Affected Resource(s)

• aws_directory_service_directory

Potential Terraform Configuration

# Example implementation, details may change during development
resource "aws_directory_service_directory" "example" {
  # ... other configuration ...

  type = "SharedMicrosoftAD"
}

References

• https://aws.amazon.com/about-aws/whats-new/2018/09/aws-directory-service-share-directory-across-accounts-and-vpcs/
• vendor: aws/[email protected] #6002

[Tensho]

I'd like to work on this ^_^ However, I found "AWS Organisation" share method impractical because it could be achieved with "Handshake" one without any extra requirements applied, like:

• AD should be in the master account
• Organisation trust enabling

Could we start with "Handshake" share method to deliver it as quickly as possible and then add "AWS Organisation"?

Also, I guess it's more appropriate to set share not as a separate type but restrict Microsoft AD type to be shared only and add block configuration for sharing options:

resource "aws_directory_service_directory" "example" {
  ...
  share {
    target = "111111111111" # acceptor account id
    notes = "Terraform will care"
  }
  ...
}

resource "aws_directory_service_directory_share_accepter" "example" {
  shared_directory_id = "${aws_directory_service_directory_share.example.shared_directory_id}"
}

[krogon]

Hi. I was able to implement whole feature of shared AWS Managed MS Directory Service for my purpose. Due to AWS API implementation the solution is a little bit different than the one provided in description.

I need a little time to prepare testing coverage as this is my first contribution.

[bwallis42]

@krogon did you finish off this feature? It would be a very useful addition.

[peter-weiss-prg]

Hi @krogon, that would be great if you can share the work you have already done over AWS Managed MS Directory Service sharing? Thank you.

[github-actions]

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.