Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tags on aws_spot_fleet_request #6627

Closed
emman27 opened this issue Nov 28, 2018 · 6 comments
Closed

Support tags on aws_spot_fleet_request #6627

emman27 opened this issue Nov 28, 2018 · 6 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@emman27
Copy link

emman27 commented Nov 28, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

As mentioned. As of now, tags can only be attached to the EC2 instances spun up but not the request itself.

Also see #2042 (comment)

New or Affected Resource(s)

  • aws_spot_fleet_request

Potential Terraform Configuration

resource "aws_spot_fleet_request" "req" {
  #... other configurations
  tags = {
        Name = "${var.name}"
    }
}

References

  • #0000
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Dec 1, 2018
@jkburges
Copy link
Contributor

Is it even possible to tag a spot fleet request itself in AWS?

I can't see anything about it in any doc or APIs (so I think it may be a limitation of AWS rather than this terraform provider).

@electroly
Copy link

It is now: https://aws.amazon.com/about-aws/whats-new/2020/02/amazon-ec2-now-supports-tagging-ec2-spot-fleet-requests/

@DrFaust92
Copy link
Collaborator

addressed in #12295

@bflad bflad added this to the v2.57.0 milestone Apr 9, 2020
@bflad
Copy link
Contributor

bflad commented Apr 9, 2020

Support for tagging Spot Fleet Requests has been merged and will release with version 2.57.0 of the Terraform AWS Provider, later today. Thanks to @DrFaust92 for the implementation. 👍

@bflad bflad closed this as completed Apr 9, 2020
@ghost
Copy link

ghost commented Apr 10, 2020

This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

No branches or pull requests

5 participants