Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Disabled property to aws_route53_health_check #8937

Closed
Glen-Moonpig opened this issue Jun 11, 2019 · 6 comments · Fixed by #14614
Closed

Add Disabled property to aws_route53_health_check #8937

Glen-Moonpig opened this issue Jun 11, 2019 · 6 comments · Fixed by #14614
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service.
Milestone

Comments

@Glen-Moonpig
Copy link
Contributor

Glen-Moonpig commented Jun 11, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

CreateHealthCheck supports creating a disabled health check, but this is not implemented in aws_route53_health_check. I want to be able to disable health checks in certain environments I am deploying to, to avoid unnecessary costs.

New or Affected Resource(s)

aws_route53_health_check

Potential Terraform Configuration

resource "aws_route53_health_check" "example" {
  disabled = "true"
}

References

  • #0000
@Glen-Moonpig Glen-Moonpig added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 11, 2019
@Glen-Moonpig Glen-Moonpig changed the title Add Disabled property to aws_route53_health_check Add Disabled property to aws_route53_health_check Jun 11, 2019
@bflad bflad added the service/route53 Issues and PRs that pertain to the route53 service. label Jun 11, 2019
@nvmsteve
Copy link

This issue appears to have been 'duplicated' multiple times, this suggests a number of people would like this feature. This one has been open for almost a year.
There are 2 pull requests (at least) to add this functionality including #10436 which was closed because it was submitted after #8939, which was closed due to inactivity.

Does anyone know how we can we progress getting this functionality added?

@Glen-Moonpig
Copy link
Contributor Author

This issue appears to have been 'duplicated' multiple times, this suggests a number of people would like this feature. This one has been open for almost a year.
There are 2 pull requests (at least) to add this functionality including #10436 which was closed because it was submitted after #8939, which was closed due to inactivity.

Does anyone know how we can we progress getting this functionality added?

It would be very useful for us to have this functionality added, but adding such basic functionality to the terraform provider is a real pain and takes considerable time, effort and skill. It would be great if AWS could just generate the code based on their API spec..

@anGie44
Copy link
Contributor

anGie44 commented Aug 13, 2020

This feature been merged and will release with v3.2.0 of the Terraform AWS Provider, expected out later today. Thanks @Glen-Moonpig for your contributions!

@Glen-Moonpig
Copy link
Contributor Author

This feature been merged and will release with v3.2.0 of the Terraform AWS Provider, expected out later today. Thanks @Glen-Moonpig for your contributions!

Thanks, glad to see this attribute finally ready to go 😅

@ghost
Copy link

ghost commented Aug 14, 2020

This has been released in version 3.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service.
Projects
None yet
4 participants