Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use directly graph.microsoft.com for non existing resources instead of azure sdk for go #235

Closed
phenixdotnet opened this issue Apr 3, 2020 · 3 comments

Comments

@phenixdotnet
Copy link

phenixdotnet commented Apr 3, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritise the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Can we implement call to graph.microsoft.com directly in this provider instead of waiting an update of the azure sdk for go ? There is an issue open to update to graph.microsoft.com but there is not ETA.

By doing this, we can add new resources and fix others if needed and use the sdk when they are ready to use MS Graph API

If this is something acceptable, I can have a look at it.

New or Affected Resource(s)

  • azuread_application

And may be with a feature flag "beta"

References

@LaurentLesle
Copy link
Contributor

yes agreed. For example I cannot delete an azure ad group when I execute terraform from a service principal. This is something the microsoft graph support through more granular api permissions. The workaround was to make local exec calls. Now with the when-destroy not supported in latest terraform It is not possible to maintain a consistent state in Azure ad resources

@manicminer
Copy link
Contributor

manicminer commented Jun 8, 2020

Hi @phenixdotnet, thanks for raising this as a potential way forward for us to begin using the Microsoft Graph API. Whilst there may be potential in this, it would not be our preferred approach and we are not yet in a position to decide on this. As this forms part of our larger strategy on migrating to MS Graph, and there is another open issue tracking this, I'm going to close this issue in favor of that one to keep discussion in one place.

@ghost
Copy link

ghost commented Jul 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants