Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development of this Terraform Provider #322

Closed
MarkDordoy opened this issue Sep 24, 2020 · 4 comments
Closed

Development of this Terraform Provider #322

MarkDordoy opened this issue Sep 24, 2020 · 4 comments
Labels

Comments

@MarkDordoy
Copy link
Contributor

@manicminer Id be really keen to start adding features to this provider that help support building and managing enterprise apps that are primarily used for SAML integrations.

The features id like to help develop would be:

  • Azure AD Policy resource
  • More features around AD Service Principals
    -- Enable SAML Endpoint
    -- Generate Signing certificates
    -- Set Notification Emails
    -- Support RelyState
  • Azure AD Application Registration
    -- Support additional changes to the app manifest

My main concern is that most, if not all the above requests interact with the Microsoft Graph, however from previous conversations with you my understanding is the GO SDK does not yet support this. However there are plans to move this provider to use this new graph since the Azure AD graph is now deprecated.

Are you able to share how you plan to make this Provider interact with the graph API. As i'd hate to try some of this, go down a particular path only to have it rejected as it does not follow the plan for this repo.

I look forward to your response.

Thanks

@manicminer
Copy link
Contributor

Hey @MarkDordoy, that's fantastic and greatly appreciated. SAML apps/integrations are a particular area where expertise is welcomed. App registrations also have a ton of featured waiting to be added.

You're right that most of everything relies on MS Graph; as I've hinted in a few threads, we're actively working on that and after checking out various potential options we decided to roll our own SDK. Most likely we'll move away from the Azure Go SDK entirely. This is still in progress - whilst being straightforward in principle we're casting a wide net and looking at autogeneration amongst other things. There's now a pinned issue on this repo #323 to publish our progress. It purposely doesn't get down to brass tacks but should give a good idea of where we're at and what our plans are.

If you aren't already a member, do consider joining our community Slack workspace (details in the project readme) - it's a great space to collaborate on details. Likewise, for the features you're looking at, consider creating issues for visibility and so they can be upvoted.

@MarkDordoy
Copy link
Contributor Author

Hey @manicminer thanks for the quick reply, I'll make sure to add myself to the slack workspace.

So while we wait for this new SDK to be ready to consume and use, would you be against raw REST api calls into a struct and go from there? Or should i wait for the first release of the SDK? I know you likely wont want to say, but do you know when the SDK in beta/Alpha will be ready to test out?

@manicminer
Copy link
Contributor

@MarkDordoy thanks for reaching out on Slack. Given that we're actively working on it, I don't think we'll merge interim implementations as it will add complexity and potential conflicts as code is refactored.

I'm going to go ahead and close this issue, as we're tracking progress in the pinned issue and further discussion is probably better suited on Slack. Thanks!

@ghost
Copy link

ghost commented Oct 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants