-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
value
on service_principal_password
is deprecated but docs still list it as required.
#479
Comments
Hi @robin-wayve , thanks for reporting this docs discrepency! We've already merged some docs changes for the upcoming v2.0 which should correctly reflect that the |
@manicminer can I confirm which version changed the behaviour? I actually saw the message about this being deprecated even on 1.4, so was wondering when it really became optional / read-only. |
@robin-wayve We issued a deprecation notice in v1.5.0 for the For the We do try and keep the changelog updated with this sort of info, whilst it might not give the full context it's the best place to look. Hope this helps clarify the changes :) |
@manicminer Thanks, this is what I was hoping was the case. 👍🏻 I did wind up reading the changelog but there aren't any references to |
In 1.5.0 there were so many deprecations, many with additional subtlety (like this one), so the changelog pointed to the Upgrade Guide. In retrospect this could have been done better, especially as the upgrade guide has since received some updates in light of the aforementioned bug in 1.5.0 I'm sorry that it wasn't made clearer in the docs that passwords would be preserved on upgrade, I will make sure to add this. |
It's all good, these changes are a nice improvement, just wanted to make sure I was upgrading safely. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Terraform (and AzureAD Provider) Version
Affected Resource(s)
azuread_service_principal_password
Terraform Configuration Files
Debug Output
Expected Behavior
The documentation should list
value
as deprecated and optional.Actual Behavior
The documentation lists
value
as required whileterraform plan
informs me the attribute is deprecated.In a test, I was also able to create a
service_principal_password
without specifying the value.Removing the value also does not modify existing resources.
Steps to Reproduce
terraform apply
Important Factoids
References
The text was updated successfully, but these errors were encountered: