-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support application gateway backend pool configuration #1027
Support application gateway backend pool configuration #1027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -940,6 +947,14 @@ func flattenAzureRmVirtualMachineScaleSetNetworkProfile(profile *compute.Virtual | |||
config["subnet_id"] = *properties.Subnet.ID | |||
} | |||
|
|||
if properties.ApplicationGatewayBackendAddressPools != nil { | |||
addressPools := make([]interface{}, 0, len(*properties.ApplicationGatewayBackendAddressPools)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this assignment out of the if statement and make this:
addressPools := make([]interface{}, 0)
if properties.ApplicationGatewayBackendAddressPools != nil {
# ...
}
config["application_gateway_backend_address_pool_ids"] = schema.NewSet(schema.HashString, addressPools)
this will ensure the application_gateway_backend_address_pool_ids
variable is set to an empty list if the field is nil (which will mean any changes are detected)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Done.
Both network interface data source and resource now supports configuration of applicaiton gateway backed pool ids.
8c069e5
to
558de7e
Compare
@tombuildsstuff thanks for the review; changed as requested. Let me know if you notice anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @abn
Thanks for pushing those changes - this now LGTM - I've kicked off the test suite and we should get the results shortly :)
Thanks!
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Support application gateway pool configuration for both vmss and network interface.
This change-set preserves code changes implemented by @agolomoodysaada in PR #884. A few changes were made to the original commit to get vmss working and verified as expected.
In addition to vmss, this also adds support for application gateway backend pool configuration for network interface resources and data sources.
Supersedes: #884
Closes #857