Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes_cluster: add None as a valid private_dns_zone_id value #10774

Merged
merged 2 commits into from
Mar 9, 2021
Merged

kubernetes_cluster: add None as a valid private_dns_zone_id value #10774

merged 2 commits into from
Mar 9, 2021

Conversation

favoretti
Copy link
Collaborator

Fixes #10769

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 aside from the value being added to the docs

@favoretti
Copy link
Collaborator Author

Ack, good spot! Will add to the docs in my morning.

@ghost ghost added the documentation label Mar 4, 2021
@katbyte katbyte added this to the v2.51.0 milestone Mar 9, 2021
@katbyte katbyte merged commit d8a7153 into hashicorp:master Mar 9, 2021
katbyte added a commit that referenced this pull request Mar 9, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.51.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for 'None' option in private_dns_zone_id parameter of azurerm_kubernetes_cluster
2 participants