Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_spring_cloud_custom_domain: thumbprint is required when specifying certificate_name #11145

Merged
merged 2 commits into from
Mar 30, 2021
Merged

azurerm_spring_cloud_custom_domain: thumbprint is required when specifying certificate_name #11145

merged 2 commits into from
Mar 30, 2021

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Mar 29, 2021

azurerm_spring_cloud_custom_domain: thumbprint is required when specifying certificate_name

@favoretti favoretti changed the title azurerm_spring_cloud_custom_domain_resource: thumbprint is required when specifying certificate_name azurerm_spring_cloud_custom_domain: thumbprint is required when specifying certificate_name Mar 29, 2021
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @favoretti! This change looks good but I'm wondering if we need that RequiredWith on certificate_name as well? Or can we specify certificate_name without a thumbprint?

@favoretti
Copy link
Collaborator Author

@mbfrahry i thought that's exactly what I was addressing. We can't have certificate_name without a thumbprint, although I haven't checked other way around. I'll try to test today.

@favoretti
Copy link
Collaborator Author

@mbfrahry You're right. Funny thing - API doesn't give any errors if one of the 2 is specified, it just never adds a certificate to a custom domain. So marking the combo as required with each other.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v2.54.0 milestone Mar 30, 2021
@mbfrahry
Copy link
Member

That is weird for sure but luckily these changes should help! Thanks again @favoretti!

@mbfrahry mbfrahry merged commit 840fdcf into hashicorp:master Mar 30, 2021
mbfrahry added a commit that referenced this pull request Mar 30, 2021
@ghost
Copy link

ghost commented Apr 2, 2021

This has been released in version 2.54.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.54.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 30, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants