-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_function_app
: Support for "client_cert_mode" and "client_cert_enabled" for Function Apps
#11161
Conversation
azurerm_function_app
: Support for "client_cert_mode" and "client_cert_enabled" for Function Apps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @howlowck
Thanks for this PR.
Taking a look through on the whole this looks pretty good - I've left some comments inline but if we can fix those up (and the tests pass) then this should be good to go 👍
Thanks!
Co-authored-by: Tom Harvey <[email protected]>
Thank you @tombuildsstuff for the review! I committed your suggestions. I need to update the code a bit from there. One issue is the dereferencing of the |
@howlowck apologies, in which case we can do |
@tombuildsstuff thanks for the guidance! I made the change regarding the enum to string conversion. I also fixed some minor logic and syntax issues. All tests now pass for data_source and resource: Data Source Test:
Resource Test:
|
Data Source Test from latest push:
|
I want to be clear on what this terraform
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @howlowck
Tests look good 👍 |
This has been released in version 2.55.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.55.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
PR closes #5006
Changes:
client_cert_mode
that takes in one of three possible values: "Required", "Optional", "Ignore"client_cert_enabled
andclient_cert_mode
on the ARM clientTestResult: