Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Sources: azurerm_key_vault & azurerm_key_vault_secret #1202

Merged
merged 10 commits into from
May 10, 2018
Merged

New Data Sources: azurerm_key_vault & azurerm_key_vault_secret #1202

merged 10 commits into from
May 10, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Key Vault Tests Pass:

$ acctests azurerm TestAccDataSourceAzureRMKeyVault_
=== RUN   TestAccDataSourceAzureRMKeyVault_basic
--- PASS: TestAccDataSourceAzureRMKeyVault_basic (220.18s)
=== RUN   TestAccDataSourceAzureRMKeyVault_complete
--- PASS: TestAccDataSourceAzureRMKeyVault_complete (194.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	414.874s

Key Vault Secret Tests Pass:

$ acctests azurerm TestAccDataSourceAzureRMKeyVaultSecret_
=== RUN   TestAccDataSourceAzureRMKeyVaultSecret_basic
--- PASS: TestAccDataSourceAzureRMKeyVaultSecret_basic (231.85s)
=== RUN   TestAccDataSourceAzureRMKeyVaultSecret_complete
--- PASS: TestAccDataSourceAzureRMKeyVaultSecret_complete (216.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	448.561s

Fixes #606

@tombuildsstuff tombuildsstuff added this to the 1.5.0 milestone May 6, 2018
@tombuildsstuff tombuildsstuff requested a review from a team May 6, 2018 13:29
@tombuildsstuff tombuildsstuff mentioned this pull request May 6, 2018
Closed
katbyte
katbyte approved these changes May 9, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from some very minor comments

website/docs/d/key_vault.html.markdown Outdated
## Example Usage

```hcl
resource "azurerm_key_vault" "test" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be data "azurerm_key_vault" "test" ?

website/docs/d/key_vault.html.markdown Outdated

* `vault_uri` - The URI of the vault for performing operations on keys and secrets.

* `location` - The Azure Region in which the Key Vault exists
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only line that doesn't end with a .

azurerm/data_source_key_vault.go
return nil
}

func flattenKeyVaultDataSourceSku(sku *keyvault.Sku) []interface{} {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, is there a reason sku is a list/block instead of a string value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also possible to set some additional fields here, but we don't expose them

website/docs/d/key_vault.html.markdown Outdated

* `name` - (Required) Specifies the name of the Key Vault.

* `resource_group_name` - The name of the Resource Group in which the Key Vault exists.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line doesn't specify if its optional or required

website/docs/d/key_vault.html.markdown Outdated
name = "mykeyvault"
resource_group_name = "some-resource-group"
}
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No output in example

website/docs/d/key_vault_secret.html.markdown Outdated
The following attributes are exported:

* `id` - The Key Vault Secret ID.
* `value` - The value of the Key Vault Secret
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only line without a .

@tombuildsstuff tombuildsstuff merged commit 7f1919d into master May 10, 2018
@tombuildsstuff tombuildsstuff deleted the data-source-keyvault branch May 10, 2018 21:39
tombuildsstuff added a commit that referenced this pull request May 10, 2018
@tombuildsstuff
Updating to include #1202
9638a19
@mikaelkrief
Copy link
Contributor

Hi,
I will be very interrested by this feature on my client.
Do you have an idea where it will be released ?
Thanks

@tombuildsstuff
Copy link
Contributor Author

@mikaelkrief it'll be released as a part of v1.5.0 very soon :)

@MikeRosTX
Copy link

Looks like a larger audience might be need this release.
https://www.facebook.com/groups/devops.engineers/permalink/850242665167530/

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@WodansSon WodansSon WodansSon approved these changes

Assignees
No one assigned
Labels
new-data-source service/key-vault Key Vault
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

azurerm_key_vault_secret as a data source?
5 participants
@tombuildsstuff @mikaelkrief @MikeRosTX @katbyte @WodansSon