Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: azurerm_route_table #1203

Merged
merged 2 commits into from
May 7, 2018
Merged

New Data Source: azurerm_route_table #1203

merged 2 commits into from
May 7, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Tests pass:

$ acctests azurerm TestAccDataSourceAzureRMRouteTable_
=== RUN   TestAccDataSourceAzureRMRouteTable_basic
--- PASS: TestAccDataSourceAzureRMRouteTable_basic (87.04s)
=== RUN   TestAccDataSourceAzureRMRouteTable_singleRoute
--- PASS: TestAccDataSourceAzureRMRouteTable_singleRoute (67.25s)
=== RUN   TestAccDataSourceAzureRMRouteTable_multipleRoutes
--- PASS: TestAccDataSourceAzureRMRouteTable_multipleRoutes (77.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	232.032s

Fixes #1155

@tombuildsstuff tombuildsstuff added this to the 1.5.0 milestone May 6, 2018
@tombuildsstuff tombuildsstuff requested a review from a team May 6, 2018 14:01
katbyte
katbyte approved these changes May 7, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from 2 minor comments

azurerm/data_source_route_table.go Outdated
ForceNew: true,
},

"resource_group_name": resourceGroupNameSchema(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be resourceGroupNameForDataSourceSchema()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fixed

website/docs/d/route_table.html.markdown

The following attributes are exported:

* `id` - The Route Table ID.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lines end with a ., some do not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fixed

@tombuildsstuff tombuildsstuff merged commit 6cef9dd into master May 7, 2018
@tombuildsstuff tombuildsstuff deleted the data-source-route-table branch May 7, 2018 12:39
tombuildsstuff added a commit that referenced this pull request May 7, 2018
@tombuildsstuff
Updating to include #1203
b2222a7
@tombuildsstuff tombuildsstuff mentioned this pull request May 7, 2018
Closed
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
new-data-source service/route-tables
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

New Data Source: azurerm_route_table
2 participants
@tombuildsstuff @katbyte