-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource azurerm_virtual_desktop_application
#12077
Conversation
@alexwilcox9 do you know when you will have time to finish this off? Have a use-case for this and I'm eager to get it into the provider and don't want to supersede your work by opening yet another PR for this :) |
@SebRosander hopefully won't be too long now, just added some tests and they are passing which is a good start
Just got to do the documentation and I'll mark this ready for review |
@alexwilcox9 Amazing! Great work, really appreciated. No worries about MSIX, we are not there yet. |
azurerm_virtual_desktop_application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanskk for the PR @alexwilcox9! overall this looks good, i've left some comments inline and no, we don't need a migration for a new resource :) i think this will be good to merge once my comments are addressed and tests pass!
Thanks for the review @katbyte I've made the changes you suggested and resolved the linting issue
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexwilcox9 - LGTM 🍰
This functionality has been released in v2.64.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Resolves #11722
I'll mark this no longer a draft when I have tests and documentation in place.
Also do I need the schema migration functions? I added them as all the other desktop virtualization resources have one but I wasn't sure if this is needed for a brand new resource?
Thanks