New Resource azurerm_virtual_desktop_application

[alexwilcox9]

Resolves #11722

I'll mark this no longer a draft when I have tests and documentation in place.
Also do I need the schema migration functions? I added them as all the other desktop virtualization resources have one but I wasn't sure if this is needed for a brand new resource?

Thanks

[SebRosander]

@alexwilcox9 do you know when you will have time to finish this off? Have a use-case for this and I'm eager to get it into the provider and don't want to supersede your work by opening yet another PR for this :)

[alexwilcox9]

@SebRosander hopefully won't be too long now, just added some tests and they are passing which is a good start
Just as a heads up I'm not looking to cover off MSIX applications in this PR as that needs an MSIX package resource created as well

$ TF_ACC=1 go test -v -timeout=2h ./azurerm/internal/services/desktopvirtualization/virtual_desktop_application_resource_test.go
2021/06/15 17:50:37 [DEBUG] not using binary driver name, it's no longer needed
2021/06/15 17:50:37 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccVirtualDesktopApplication_basic
=== PAUSE TestAccVirtualDesktopApplication_basic
=== RUN   TestAccVirtualDesktopApplication_complete
=== PAUSE TestAccVirtualDesktopApplication_complete
=== RUN   TestAccVirtualDesktopApplication_update
=== PAUSE TestAccVirtualDesktopApplication_update
=== RUN   TestAccVirtualDesktopApplication_requiresImport
=== PAUSE TestAccVirtualDesktopApplication_requiresImport
=== CONT  TestAccVirtualDesktopApplication_basic
=== CONT  TestAccVirtualDesktopApplication_requiresImport
=== CONT  TestAccVirtualDesktopApplication_complete
=== CONT  TestAccVirtualDesktopApplication_update
--- PASS: TestAccVirtualDesktopApplication_complete (105.53s)
--- PASS: TestAccVirtualDesktopApplication_basic (106.64s)
--- PASS: TestAccVirtualDesktopApplication_requiresImport (123.00s)
--- PASS: TestAccVirtualDesktopApplication_update (180.66s)
PASS
ok      command-line-arguments  180.764s

Just got to do the documentation and I'll mark this ready for review

[SebRosander]

@alexwilcox9 Amazing! Great work, really appreciated. No worries about MSIX, we are not there yet.

[katbyte]

Thanskk for the PR @alexwilcox9! overall this looks good, i've left some comments inline and no, we don't need a migration for a new resource :) i think this will be good to merge once my comments are addressed and tests pass!

[alexwilcox9]

Thanks for the review @katbyte I've made the changes you suggested and resolved the linting issue
Tests are still looking good, hopefully this is good to go now

$ TF_ACC=1 go test -v -timeout=2h ./azurerm/internal/services/desktopvirtualization/virtual_desktop_application_resource_test.go 
2021/06/16 11:44:43 [DEBUG] not using binary driver name, it's no longer needed
2021/06/16 11:44:43 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccVirtualDesktopApplication_basic
=== PAUSE TestAccVirtualDesktopApplication_basic
=== RUN   TestAccVirtualDesktopApplication_complete
=== PAUSE TestAccVirtualDesktopApplication_complete
=== RUN   TestAccVirtualDesktopApplication_update
=== PAUSE TestAccVirtualDesktopApplication_update
=== RUN   TestAccVirtualDesktopApplication_requiresImport
=== PAUSE TestAccVirtualDesktopApplication_requiresImport
=== CONT  TestAccVirtualDesktopApplication_basic
=== CONT  TestAccVirtualDesktopApplication_requiresImport
=== CONT  TestAccVirtualDesktopApplication_update
=== CONT  TestAccVirtualDesktopApplication_complete
--- PASS: TestAccVirtualDesktopApplication_complete (108.81s)
--- PASS: TestAccVirtualDesktopApplication_basic (109.07s)
--- PASS: TestAccVirtualDesktopApplication_requiresImport (128.60s)
--- PASS: TestAccVirtualDesktopApplication_update (187.11s)
PASS
ok      command-line-arguments  187.223s

[katbyte]

Thanks @alexwilcox9 - LGTM 🍰

[github-actions]

This functionality has been released in v2.64.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.