Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New data source: azurerm_consumption_budget_resource_group #12538

Merged
merged 25 commits into from
Oct 14, 2021
Merged

New data source: azurerm_consumption_budget_resource_group #12538

merged 25 commits into from
Oct 14, 2021

Conversation

gro1m
Copy link
Contributor

@gro1m gro1m commented Jul 9, 2021

Base off #12150.

@gro1m gro1m changed the title D/azurerm_consumption_budget_resource_group D/azurerm_consumption_budget_resource_group Jul 9, 2021
@gro1m gro1m changed the title D/azurerm_consumption_budget_resource_group D/azurerm_consumption_budget_resource_group Jul 9, 2021
@gro1m gro1m changed the title D/azurerm_consumption_budget_resource_group D/azurerm_consumption_budget_resource_group Jul 9, 2021
@gro1m gro1m changed the title D/azurerm_consumption_budget_resource_group D/azurerm_consumption_budget_resource_group Jul 9, 2021
@github-actions github-actions bot added size/L and removed size/XL labels Jul 9, 2021
@katbyte katbyte mentioned this pull request Jul 9, 2021
Closed
@manicminer manicminer changed the title D/azurerm_consumption_budget_resource_group New data source: azurerm_consumption_budget_resource_group Jul 14, 2021
jackofallops
jackofallops requested changes Aug 26, 2021
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gro1m - Thanks for this and apologies for the delay in review. I've left some comments below on changes required. I've only reviewed the resource so far, as the changes will mean the the tests and docs need updating, so I'll continue once those are addressed.
Thanks again.

azurerm/internal/services/consumption/consumption_budget_resource_group_data_source.go Outdated Show resolved Hide resolved
azurerm/internal/services/consumption/consumption_budget_resource_group_data_source.go Outdated Show resolved Hide resolved
azurerm/internal/services/consumption/consumption_budget_resource_group_data_source.go Outdated Show resolved Hide resolved
azurerm/internal/services/consumption/consumption_budget_resource_group_data_source.go Outdated Show resolved Hide resolved
azurerm/internal/services/consumption/consumption_budget_resource_group_data_source.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/XL and removed size/L labels Sep 21, 2021
stephybun
stephybun requested changes Oct 8, 2021
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gro1m, thanks for your patience. I hope you don't mind that I jumped in at this point to fix up the acceptance test and part of the data source. Feel free to reach out to me if you have any questions about the changes I made. The test runs now and I left a TODO in there for adding the remaining checks, also there are a few comments regarding the schema that need to be addressed before we can merge this. I'm also happy to finish this up if you'd like, thought you might like to have another crack at it though.

internal/services/consumption/consumption_budget_resource_group_data_source.go Outdated Show resolved Hide resolved
internal/services/consumption/consumption_budget_resource_group_data_source.go Outdated Show resolved Hide resolved
internal/services/consumption/consumption_budget_resource_group_data_source.go Outdated Show resolved Hide resolved
internal/services/consumption/consumption_budget_resource_group_data_source.go Outdated Show resolved Hide resolved
internal/services/consumption/consumption_budget_resource_group_data_source.go Outdated Show resolved Hide resolved
@gro1m gro1m mentioned this pull request Oct 9, 2021
Merged
@gro1m gro1m requested a review from stephybun October 9, 2021 21:23
stephybun
stephybun previously requested changes Oct 11, 2021
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a suggestion on how the schema should look like for those Elem blocks. It would need to be applied to all the other ones too.

internal/services/consumption/consumption_budget_resource_group_data_source.go Outdated Show resolved Hide resolved
internal/services/consumption/consumption_budget_resource_group_data_source_test.go Show resolved Hide resolved
@gro1m gro1m requested a review from stephybun October 11, 2021 18:11
stephybun
stephybun reviewed Oct 13, 2021
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gro1m for setting those properties to Computed. I finished up the test and docs. Since I made a few adjustments i've asked @jackofallops to do a final review before we merge this 🙂.

jackofallops
jackofallops approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gro1m and @stephybun - This LGTM 🚀

@jackofallops jackofallops added this to the v2.81.0 milestone Oct 14, 2021
@stephybun stephybun merged commit d356e1f into hashicorp:main Oct 14, 2021
stephybun added a commit that referenced this pull request Oct 14, 2021
@stephybun
Update for #12538 and #12540
68e804a
@github-actions
Copy link

This functionality has been released in v2.81.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun left review comments

@jackofallops jackofallops jackofallops approved these changes

Assignees

@jackofallops jackofallops

Labels
documentation new-data-source service/consumption size/XL
Projects
None yet
Milestone
v2.81.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gro1m @jackofallops @stephybun @manicminer