-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_eventgrid_event_subscription/azurerm_eventgrid_system_topic_event_subscription - support delivery_identity & dead_letter_identity #12945
Conversation
This is supported in the API but isn't exposed in the SDK/Swagger Upstream issue: Azure/azure-rest-api-specs#13340
…ocks are always set
…markdown Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
…nt_subscription_resource_test.go Co-authored-by: Tom Harvey <[email protected]>
…on_resource_test.go Co-authored-by: Tom Harvey <[email protected]>
azurerm_event_grid_subscription
azurerm_event_grid_subscription
r/azurerm_eventgrid_event_subscription
r/azurerm_eventgrid_event_subscription
r/azurerm_eventgrid_event_subscription
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reopening this @jrauschenbusch. If we can fix up that one failing test then this LGTM 👍🏼
internal/services/eventgrid/eventgrid_system_topic_event_subscription_resource_test.go
Outdated
Show resolved
Hide resolved
…ription_resource_test.go Co-authored-by: stephybun <[email protected]>
@stephybun Done |
r/azurerm_eventgrid_event_subscription
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks both! LGTM 🏗️
This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
@katbyte Reopened PR after fixing tests.
References:
#9526
#9935
Please give me fast feedback if changes are needed, as i don't have that much spare time to be up with long running reviews.