Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_eventgrid_event_subscription/azurerm_eventgrid_system_topic_event_subscription - support delivery_identity & dead_letter_identity #12945

Merged
merged 13 commits into from
Sep 3, 2021
Merged

azurerm_eventgrid_event_subscription/azurerm_eventgrid_system_topic_event_subscription - support delivery_identity & dead_letter_identity #12945

merged 13 commits into from
Sep 3, 2021

Conversation

jrauschenbusch
Copy link
Contributor

@jrauschenbusch jrauschenbusch commented Aug 11, 2021 •
edited
Loading

@katbyte Reopened PR after fixing tests.

References:
#9526
#9935

Please give me fast feedback if changes are needed, as i don't have that much spare time to be up with long running reviews.

jrauschenbusch and others added 12 commits August 11, 2021 11:08
@jrauschenbusch
eventgrid event subscription managed identity support
23337c0
@tombuildsstuff @jrauschenbusch
eventgrid: supporting the hidden None value
265f83a 
This is supported in the API but isn't exposed in the SDK/Swagger

Upstream issue: Azure/azure-rest-api-specs#13340
@tombuildsstuff @jrauschenbusch
r/eventgrid_event_subscription: ensuring the identity blocks are alwa…
33bf785 
…ys set
@tombuildsstuff @jrauschenbusch
r/eventgrid_system_topic_event_subscription: ensuring the identity bl…
c20a93a 
…ocks are always set
@jrauschenbusch @tombuildsstuff
Update website/docs/r/eventgrid_system_topic_event_subscription.html.…
97aaf4d 
…markdown

Co-authored-by: Tom Harvey <[email protected]>
@jrauschenbusch @tombuildsstuff
Update website/docs/r/eventgrid_event_subscription.html.markdown
c1a0fe8 
Co-authored-by: Tom Harvey <[email protected]>
@jrauschenbusch @tombuildsstuff
Update azurerm/internal/services/eventgrid/eventgrid_system_topic_eve…
c389287 
…nt_subscription_resource_test.go

Co-authored-by: Tom Harvey <[email protected]>
@jrauschenbusch @tombuildsstuff
Update azurerm/internal/services/eventgrid/eventgrid_event_subscripti…
eb88864 
…on_resource_test.go

Co-authored-by: Tom Harvey <[email protected]>
@jrauschenbusch
fix fmt
0801766
@jrauschenbusch
cleanup test
f5a63da
@jrauschenbusch
fix: rebase
fc0c17b
@jrauschenbusch
fix: tests
48cb000
@jrauschenbusch jrauschenbusch changed the title Support for Event Grid Event Subscription system managed identity Support for Event Grid Event Subscription system managed identity azurerm_event_grid_subscription Aug 12, 2021
@jrauschenbusch jrauschenbusch changed the title Support for Event Grid Event Subscription system managed identity azurerm_event_grid_subscription Support for Event Grid Event Subscription system managed identity r/azurerm_eventgrid_event_subscription Aug 12, 2021
@jrauschenbusch jrauschenbusch changed the title Support for Event Grid Event Subscription system managed identity r/azurerm_eventgrid_event_subscription Support for System Managed Identity in r/azurerm_eventgrid_event_subscription Aug 12, 2021
stephybun
stephybun requested changes Sep 3, 2021
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reopening this @jrauschenbusch. If we can fix up that one failing test then this LGTM 👍🏼

internal/services/eventgrid/eventgrid_system_topic_event_subscription_resource_test.go Outdated Show resolved Hide resolved
@jrauschenbusch
Copy link
Contributor Author

@stephybun Done

@katbyte katbyte added this to the v2.76.0 milestone Sep 3, 2021
@katbyte katbyte changed the title Support for System Managed Identity in r/azurerm_eventgrid_event_subscription azurerm_eventgrid_event_subscription/azurerm_eventgrid_system_topic_event_subscription - support delivery_identity & dead_letter_identity Sep 3, 2021
katbyte
katbyte approved these changes Sep 3, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both! LGTM 🏗️

@katbyte katbyte merged commit f457383 into hashicorp:main Sep 3, 2021
katbyte added a commit that referenced this pull request Sep 3, 2021
@katbyte
CHANGELOG.md for #12945
9720085
@github-actions
Copy link

This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun requested changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/event-grid EventGrid size/XL
Projects
None yet
Milestone
v2.76.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jrauschenbusch @katbyte @stephybun @tombuildsstuff