Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/azurerm_public_ips: Deprecate attached for attachment_status #13500

Merged
merged 3 commits into from
Oct 5, 2021
Merged

d/azurerm_public_ips: Deprecate attached for attachment_status #13500

merged 3 commits into from
Oct 5, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Sep 24, 2021 •
edited
Loading

Fixes #13497

Solution

attachment_status contains both the option to select based on the status (what is currently supported by attached = true/false -> attachment_status = "Attached"/"Unattached") and to select all in one go ( attachment_status = "All" ).

At 3.0, default will show all IPs, attached or not

@aristosvo aristosvo marked this pull request as ready for review September 24, 2021 19:02
@jackofallops jackofallops requested a review from a team October 1, 2021 08:26
@jackofallops jackofallops added this to the v2.80.0 milestone Oct 1, 2021
jackofallops
jackofallops requested changes Oct 1, 2021
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aristosvo - many thanks for this. Just a couple of minor things to address and I think this will be good to test and merge.

website/docs/d/public_ips.html.markdown Outdated Show resolved Hide resolved
internal/services/network/public_ips_data_source.go Show resolved Hide resolved
jackofallops
jackofallops approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops jackofallops merged commit 7bf999d into hashicorp:main Oct 5, 2021
jackofallops added a commit that referenced this pull request Oct 5, 2021
@jackofallops
Update for #13500
9fd12b2
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This functionality has been released in v2.80.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
documentation size/S
Projects
None yet
Milestone
v2.80.0
Development

Successfully merging this pull request may close these issues.

Empty list with azurerm_public_ips without filters
2 participants
@aristosvo @jackofallops