-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Factory - Global Parameters, bug fix while reading editted or existing global parameter values #13519
Conversation
… and Object types to json encoded strings
…anges under expandDataFactoryGlobalParameters
Found with these changes if I have added a Note to the docs recommending the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andy-mcgrath, looks good, just one query about the casing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @andy-mcgrath! LGTM now 😄
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
resourceDataFactoryRead
,flattenDataFactoryGlobalParameters
set to convert Array and Object types to JSON encoded stringThis is due to the type returned by the API can be the declared type or a string. This change converts the actual global parameter values to a string to compare with the state.
This removes the following error
Resolves #12301