-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_service_bus_queue|topic
: Support for max_message_size_in_kilobytes
for Premium SKU
#13762
azurerm_service_bus_queue|topic
: Support for max_message_size_in_kilobytes
for Premium SKU
#13762
Conversation
max_message_size_in_kilobytes
max_message_size_in_kilobytes
azurerm_service_bus_queue|topic
: Support for max_message_size_in_kilobytes
azurerm_service_bus_queue|topic
: Support for max_message_size_in_kilobytes
azurerm_service_bus_queue|topic
: Support for max_message_size_in_kilobytes
for Premium SKU
2665ca6
to
e5bf3c3
Compare
e5bf3c3
to
f91e1ec
Compare
Rebased and specific tests run again: --- PASS: TestAccServiceBusTopic_maxMessageSizePremium (369.36s)
--- PASS: TestAccServiceBusQueue_maxMessageSizePremium (626.95s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/servicebus 628.530s |
Hmm, unfortunately looks like there are a lot of test failures for this PR:
|
This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Oops, sorry! I didn't expect any return on the property in non-Premium SKU situations, which is apparently the case. This should solve it. --- PASS: TestAccServiceBusTopic_update (331.45s)
--- PASS: TestAccServiceBusTopic_maxMessageSizePremium (357.12s)
--- PASS: TestAccServiceBusQueue_maxMessageSizePremium (360.29s)
--- PASS: TestAccServiceBusQueue_update (478.95s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/servicebus 480.451s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aristosvo - LGTM ⛏️
This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Builds on #13760
Fixes #13514
Acceptance Tests