Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade API version for azurerm_mysql_flexible_server #13818

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Oct 21, 2021

Service team released a new stable API version 2021-05-01 for MySql Flexible Server. So submitted this PR to update the API version to stable one. Service team confirmed the contents among two versions are same.

--- PASS: TestAccMySqlFlexibleServer_basic (604.64s)
--- PASS: TestAccMySqlFlexibleServer_updateStorage (975.47s)
--- PASS: TestAccMySqlFlexibleServer_updateMaintenanceWindow (1003.09s)
--- PASS: TestAccMySqlFlexibleServer_requiresImport (554.62s)
--- PASS: TestAccMySqlFlexibleServer_complete (1669.00s)
--- PASS: TestAccMySqlFlexibleServer_failover (1676.24s)
--- PASS: TestAccMySqlFlexibleServer_updateSku (1679.46s)
--- PASS: TestAccMySqlFlexibleServer_pitr (2225.32s)
--- PASS: TestAccMySqlFlexibleServer_geoRestore (2270.78s)
--- PASS: TestAccMySqlFlexibleServer_replica (2453.04s)
--- PASS: TestAccMySqlFlexibleServer_updateReplicationRole (2820.29s)
--- PASS: TestAccMySqlFlexibleServer_completeUpdate (2278.14s)
--- PASS: TestAccMySqlFlexibleServer_updateHA (3503.92s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei - aside from the merge conflict to resolve this LGTM me 🏗️

@katbyte katbyte merged commit 7498472 into hashicorp:main Oct 25, 2021
katbyte added a commit that referenced this pull request Oct 25, 2021
@neil-yechenwei
Copy link
Contributor Author

@katbyte , I found a check failure. I fixed in PR. Please take a look. Thanks.

@github-actions
Copy link

This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants