Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_machine_learning_compute_cluster, azurerm_machine_learning_compute_cluster, azurerm_machine_learning_synapse_spark - support for local_auth_enabled #13820

Merged

Conversation

ms-henglu
Copy link
Contributor

No description provided.

@katbyte
Copy link
Collaborator

katbyte commented Oct 21, 2021

Looks like we have a test failure:

------- Stdout: -------
=== RUN   TestAccComputeInstance_complete
=== PAUSE TestAccComputeInstance_complete
=== CONT  TestAccComputeInstance_complete
    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Subnet: (Name "internal" / Virtual Network Name "acctest21102183" / Resource Group "acctestRG-ml-211021215647677883"): network.SubnetsClient#Delete: Failure sending request: StatusCode=400 -- Original Error: Code="InUseSubnetCannotBeDeleted" Message="Subnet internal is in use by /subscriptions/6f0c81c6-8c1e-44be-834a-6818378c1b83/resourceGroups/c185c517-19c5-43ee-bf68-7875ba800082-AzureBatch-CloudService/providers/Microsoft.Network/networkInterfaces/|providers|Microsoft.Compute|virtualMachineScaleSets|c185c517-19c5-43ee-bf68-7875ba800082-AzureBatch-Deployment|virtualMachines|1|networkInterfaces|nic1/ipConfigurations/ip1 and cannot be deleted. In order to delete the subnet, delete all the resources within the subnet. See aka.ms/deletesubnet." Details=[]
        
--- FAIL: TestAccComputeInstance_complete (935.12s)

@ms-henglu
Copy link
Contributor Author

@katbyte , thanks! I've taken a look, the cause is error deleting a subnet used by compute instance, and we delete the compute instance before deleting subnet. It seems some internal resources still use the subnet, I've reported it to service team and ask them help with it.

@tombuildsstuff tombuildsstuff added the upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR label Oct 29, 2021
@tombuildsstuff tombuildsstuff added this to the Blocked milestone Oct 29, 2021
@tombuildsstuff
Copy link
Contributor

Marked as blocked on the Service Team - @ms-henglu is there an upstream ticket tracking that?

@ms-henglu
Copy link
Contributor Author

@tombuildsstuff , Yes, there is

@ms-henglu
Copy link
Contributor Author

image

Test passed in local

@ms-henglu
Copy link
Contributor Author

@katbyte , Hi, I run tests on tc again, though there still are some failures, but the cause is exist key vault error. The TestAccComputeInstance_complete test is passed. Please take another look, thanks!

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM< 🔥

@katbyte katbyte modified the milestones: Blocked, v2.84.0 Nov 3, 2021
@katbyte katbyte changed the title machine learning compute supports local_auth_enabled azurerm_machine_learning_compute_cluster, azurerm_machine_learning_compute_cluster, azurerm_machine_learning_synapse_spark - support for local_auth_enabled Nov 3, 2021
@katbyte katbyte merged commit 1c2f563 into hashicorp:main Nov 3, 2021
katbyte added a commit that referenced this pull request Nov 3, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation enhancement service/machine-learning size/M upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants