Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_smart_detector_alert_rule: Support additional detector types #13998

Merged
merged 1 commit into from
Nov 2, 2021
Merged

azurerm_monitor_smart_detector_alert_rule: Support additional detector types #13998

merged 1 commit into from
Nov 2, 2021

Conversation

gjermystreeva
Copy link
Contributor

@gjermystreeva gjermystreeva commented Nov 2, 2021

PR raised to implement #13997

Azure Monitor App Insights now supports additional detector types "RequestPerformanceDegradationDetector", "DependencyPerformanceDegradationDetector", "ExceptionVolumeChangedDetector", "TraceSeverityDetector", "MemoryLeakDetector" as smart detection alerts.

See Migrate Azure Monitor Application Insights smart detection to alerts (Preview)

This PR updates the client side validation to allow the additional detector types for azurerm_monitor_smart_detector_alert_rule to be deployable via Terraform.

Once deployed the alert rules are understood as Signal Type = "Smart Detector" with the Condition text populated by Azure.
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gjermystreeva - LGTM 🏗️ '

@katbyte katbyte merged commit edb5b0d into hashicorp:main Nov 2, 2021
katbyte added a commit that referenced this pull request Nov 2, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants