-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource azurerm_stream_analytics_output_synapse
#14013
Conversation
Signed-off-by: Owen Farrell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @owenfarrell. This is almost good to go, just a few suggestions and waiting for the tests to run through 🙂.
internal/services/streamanalytics/stream_analytics_output_synapse_resource.go
Outdated
Show resolved
Hide resolved
internal/services/streamanalytics/stream_analytics_output_synapse_resource.go
Outdated
Show resolved
Hide resolved
internal/services/streamanalytics/stream_analytics_output_synapse_resource.go
Outdated
Show resolved
Hide resolved
internal/services/streamanalytics/stream_analytics_output_synapse_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/streamanalytics/stream_analytics_output_synapse_resource_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: stephybun <[email protected]> Signed-off-by: Owen Farrell <[email protected]>
d52b449
to
d48b013
Compare
@stephybun - All updates incorporated. I may have gone overboard on the stream analytics type calculation, but I tried to replicate the existing pattern, which should help incorporate type validation in to the other stream analytics output resource types as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @owenfarrell! LGTM 🚀
This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Summary
This pull request adds a new resource to manage a Stream Analytics output to a Synapse Workspace.
Fixes: #8881
Output from acceptance testing: