Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource azurerm_stream_analytics_output_synapse #14013

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

owenfarrell
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Summary

This pull request adds a new resource to manage a Stream Analytics output to a Synapse Workspace.

Fixes: #8881

Output from acceptance testing:

$ make acctests SERVICE='streamanalytics' TESTARGS='-run="^TestAccStreamAnalyticsOutputSynapse_"'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/streamanalytics -run="^TestAccStreamAnalyticsOutputSynapse_" -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccStreamAnalyticsOutputSynapse_basic
=== PAUSE TestAccStreamAnalyticsOutputSynapse_basic
=== RUN   TestAccStreamAnalyticsOutputSynapse_sqlPool
=== PAUSE TestAccStreamAnalyticsOutputSynapse_sqlPool
=== RUN   TestAccStreamAnalyticsOutputSynapse_update
=== PAUSE TestAccStreamAnalyticsOutputSynapse_update
=== RUN   TestAccStreamAnalyticsOutputSynapse_requiresImport
=== PAUSE TestAccStreamAnalyticsOutputSynapse_requiresImport
=== CONT  TestAccStreamAnalyticsOutputSynapse_basic
=== CONT  TestAccStreamAnalyticsOutputSynapse_update
=== CONT  TestAccStreamAnalyticsOutputSynapse_requiresImport
=== CONT  TestAccStreamAnalyticsOutputSynapse_sqlPool
--- PASS: TestAccStreamAnalyticsOutputSynapse_basic (629.72s)
--- PASS: TestAccStreamAnalyticsOutputSynapse_requiresImport (794.48s)
--- PASS: TestAccStreamAnalyticsOutputSynapse_update (895.11s)
--- PASS: TestAccStreamAnalyticsOutputSynapse_sqlPool (1147.35s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/streamanalytics       1150.196s

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @owenfarrell. This is almost good to go, just a few suggestions and waiting for the tests to run through 🙂.

Co-authored-by: stephybun <[email protected]>
Signed-off-by: Owen Farrell <[email protected]>
@owenfarrell
Copy link
Contributor Author

@stephybun - All updates incorporated. I may have gone overboard on the stream analytics type calculation, but I tried to replicate the existing pattern, which should help incorporate type validation in to the other stream analytics output resource types as well.

@katbyte katbyte added this to the v2.84.0 milestone Nov 4, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @owenfarrell! LGTM 🚀

@katbyte katbyte merged commit 2a6360c into hashicorp:main Nov 4, 2021
katbyte added a commit that referenced this pull request Nov 4, 2021
@owenfarrell owenfarrell deleted the synapse-stream-analytics branch November 4, 2021 23:07
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Stream Analytics Output to Synapse
3 participants