Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/app_service_slot: Add support for enabling MSI #1579

Merged
merged 2 commits into from
Jul 16, 2018

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jul 15, 2018

Fixes #1268

Test results in the comments below thanks to @tombuildsstuff

@stack72 stack72 changed the title [WIP] resource/app_service_slot: Add support for enabling MSI resource/app_service_slot: Add support for enabling MSI Jul 15, 2018
@stack72 stack72 changed the title resource/app_service_slot: Add support for enabling MSI [WIP] resource/app_service_slot: Add support for enabling MSI Jul 15, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

screenshot 2018-07-16 at 08 25 27

@tombuildsstuff tombuildsstuff changed the title [WIP] resource/app_service_slot: Add support for enabling MSI resource/app_service_slot: Add support for enabling MSI Jul 16, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this 👍

@tombuildsstuff tombuildsstuff added this to the 1.10.0 milestone Jul 16, 2018
@tombuildsstuff tombuildsstuff merged commit e992995 into hashicorp:master Jul 16, 2018
tombuildsstuff added a commit that referenced this pull request Jul 16, 2018
@tombuildsstuff
Copy link
Contributor

hi @stack72

Just to let you know that is now available in [v1.10 of the AzureRM Provider(https://github.com/terraform-providers/terraform-provider-azurerm/blob/v1.10.0/CHANGELOG.md#1100-july-21-2018) - which you can update to this version by specifying it in the Provider block, like so:

provider "azurerm" {
  version = "=1.10.0"
}

Thanks!

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MSI support also for app service deployment slots
2 participants