Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ID of an embedded subnet defined in azurerm_virtual_network #1913

Merged
merged 5 commits into from
Sep 28, 2018

Conversation

JunyiYi
Copy link

@JunyiYi JunyiYi commented Sep 12, 2018

  • Add test cases to verify ID is actually set
  • Add documentation and sample code to explain how to reference the subnet ID
  • Expose the subnet ID in azurerm_virtual_network resource

Actually it is hard to reference a specific subnet element in the current implementation because of the hash function. But that is a different story and requires state migration as well. So I just keep it as a small change in this PR.

The PR enables user referencing the subnet ID defined in azurerm_virtual_network resource mentioned in issue #666 .

Fixes #666

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @JunyiYi

Thanks for this PR - if we can fix the documentation issues flagged below this otherwise LGTM 👍

Thanks!

website/docs/r/virtual_network.html.markdown Outdated Show resolved Hide resolved
website/docs/r/virtual_network.html.markdown Outdated Show resolved Hide resolved
website/docs/r/virtual_network.html.markdown Outdated Show resolved Hide resolved
@ghost ghost added the size/M label Sep 12, 2018
@JunyiYi JunyiYi self-assigned this Sep 13, 2018
@JunyiYi JunyiYi added this to the Soon milestone Sep 13, 2018
@tombuildsstuff tombuildsstuff modified the milestones: Soon, 1.16.0 Sep 27, 2018
@ghost ghost added size/S and removed size/M labels Sep 27, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the sample's been removed this now LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests pass (now that #1985 has been temporarily reverted):

screenshot 2018-09-29 at 08 13 08

@tombuildsstuff tombuildsstuff merged commit 5d28e73 into master Sep 28, 2018
@tombuildsstuff tombuildsstuff deleted the expose_embedsubnet_id branch September 28, 2018 22:14
tombuildsstuff added a commit that referenced this pull request Sep 28, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants