Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resources: Shared Image Galleries #1987

Merged
merged 15 commits into from
Oct 1, 2018
Merged

New Resources: Shared Image Galleries #1987

merged 15 commits into from
Oct 1, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Sep 27, 2018 •
edited
Loading

This PR adds support for Shared Image Galleries - which have been recently announced at Ignite - more details are available in #1986.

Tasks:

  • New Resource: azurerm_shared_image_gallery
  • New Data Source: azurerm_shared_image_gallery
  • New Resource: azurerm_shared_image
  • New Data Source: azurerm_shared_image
  • New Resource: azurerm_shared_image_version
  • New Data Source: azurerm_shared_image_version
  • Preview Notices

Fixes #1986

@tombuildsstuff tombuildsstuff added this to the 1.16.0 milestone Sep 27, 2018
@ghost ghost added the size/XXL label Sep 27, 2018
@tombuildsstuff tombuildsstuff changed the title New Resources: Shared Image Galleries [WIP] New Resources: Shared Image Galleries Sep 27, 2018
@ghost ghost added the size/XXL label Sep 27, 2018
@tombuildsstuff tombuildsstuff mentioned this pull request Sep 27, 2018
Merged
@tombuildsstuff tombuildsstuff changed the title [WIP] New Resources: Shared Image Galleries New Resources: Shared Image Galleries Sep 28, 2018
@tombuildsstuff tombuildsstuff requested a review from a team September 28, 2018 09:14
katbyte
katbyte approved these changes Sep 28, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombuildsstuff LGTM 👍

@tombuildsstuff
Registeringg the Image Galleries clients
a661d96
@tombuildsstuff
Validation for Shared Image Versions
1f0b410 
```
$ go test -v ./azurerm/helpers/validate/
=== RUN   TestSharedImageGalleryName
=== RUN   TestSharedImageGalleryName/#00
=== RUN   TestSharedImageGalleryName/a.b.c
=== RUN   TestSharedImageGalleryName/1.2.3
=== RUN   TestSharedImageGalleryName/0.0.1
=== RUN   TestSharedImageGalleryName/hello
=== RUN   TestSharedImageGalleryName/1.2.3.4
=== RUN   TestSharedImageGalleryName/hell0-there
--- PASS: TestSharedImageGalleryName (0.00s)
    --- PASS: TestSharedImageGalleryName/#00 (0.00s)
    --- PASS: TestSharedImageGalleryName/a.b.c (0.00s)
    --- PASS: TestSharedImageGalleryName/1.2.3 (0.00s)
    --- PASS: TestSharedImageGalleryName/0.0.1 (0.00s)
    --- PASS: TestSharedImageGalleryName/hello (0.00s)
    --- PASS: TestSharedImageGalleryName/1.2.3.4 (0.00s)
    --- PASS: TestSharedImageGalleryName/hell0-there (0.00s)
=== RUN   TestIPv4Address
=== RUN   TestIPv4Address/#00
=== RUN   TestIPv4Address/0.0.0.0
=== RUN   TestIPv4Address/1.2.3.no
=== RUN   TestIPv4Address/text
=== RUN   TestIPv4Address/1.2.3.4
=== RUN   TestIPv4Address/12.34.43.21
=== RUN   TestIPv4Address/100.123.199.0
=== RUN   TestIPv4Address/255.255.255.255
--- PASS: TestIPv4Address (0.00s)
    --- PASS: TestIPv4Address/#00 (0.00s)
    --- PASS: TestIPv4Address/0.0.0.0 (0.00s)
    --- PASS: TestIPv4Address/1.2.3.no (0.00s)
    --- PASS: TestIPv4Address/text (0.00s)
    --- PASS: TestIPv4Address/1.2.3.4 (0.00s)
    --- PASS: TestIPv4Address/12.34.43.21 (0.00s)
    --- PASS: TestIPv4Address/100.123.199.0 (0.00s)
    --- PASS: TestIPv4Address/255.255.255.255 (0.00s)
=== RUN   TestIPv4AddressOrEmpty
=== RUN   TestIPv4AddressOrEmpty/#00
=== RUN   TestIPv4AddressOrEmpty/0.0.0.0
=== RUN   TestIPv4AddressOrEmpty/1.2.3.no
=== RUN   TestIPv4AddressOrEmpty/text
=== RUN   TestIPv4AddressOrEmpty/1.2.3.4
=== RUN   TestIPv4AddressOrEmpty/12.34.43.21
=== RUN   TestIPv4AddressOrEmpty/100.123.199.0
=== RUN   TestIPv4AddressOrEmpty/255.255.255.255
--- PASS: TestIPv4AddressOrEmpty (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/#00 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/0.0.0.0 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/1.2.3.no (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/text (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/1.2.3.4 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/12.34.43.21 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/100.123.199.0 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/255.255.255.255 (0.00s)
=== RUN   TestMACAddress
=== RUN   TestMACAddress/#00
=== RUN   TestMACAddress/text_d
=== RUN   TestMACAddress/12:34:no
=== RUN   TestMACAddress/123:34:56:78:90:ab
=== RUN   TestMACAddress/12:34:56:78:90:NO
=== RUN   TestMACAddress/12:34:56:78:90:ab
=== RUN   TestMACAddress/ab:cd:ef:AB:CD:EF
--- PASS: TestMACAddress (0.00s)
    --- PASS: TestMACAddress/#00 (0.00s)
    --- PASS: TestMACAddress/text_d (0.00s)
    --- PASS: TestMACAddress/12:34:no (0.00s)
    --- PASS: TestMACAddress/123:34:56:78:90:ab (0.00s)
    --- PASS: TestMACAddress/12:34:56:78:90:NO (0.00s)
    --- PASS: TestMACAddress/12:34:56:78:90:ab (0.00s)
    --- PASS: TestMACAddress/ab:cd:ef:AB:CD:EF (0.00s)
=== RUN   TestPortNumber
=== RUN   TestPortNumber/-1
=== RUN   TestPortNumber/0
=== RUN   TestPortNumber/1
=== RUN   TestPortNumber/8477
=== RUN   TestPortNumber/65535
=== RUN   TestPortNumber/65536
=== RUN   TestPortNumber/7000000
--- PASS: TestPortNumber (0.00s)
    --- PASS: TestPortNumber/-1 (0.00s)
    --- PASS: TestPortNumber/0 (0.00s)
    --- PASS: TestPortNumber/1 (0.00s)
    --- PASS: TestPortNumber/8477 (0.00s)
    --- PASS: TestPortNumber/65535 (0.00s)
    --- PASS: TestPortNumber/65536 (0.00s)
    --- PASS: TestPortNumber/7000000 (0.00s)
=== RUN   TestPortNumberOrZero
=== RUN   TestPortNumberOrZero/-1
=== RUN   TestPortNumberOrZero/0
=== RUN   TestPortNumberOrZero/1
=== RUN   TestPortNumberOrZero/8477
=== RUN   TestPortNumberOrZero/65535
=== RUN   TestPortNumberOrZero/65536
=== RUN   TestPortNumberOrZero/7000000
--- PASS: TestPortNumberOrZero (0.00s)
    --- PASS: TestPortNumberOrZero/-1 (0.00s)
    --- PASS: TestPortNumberOrZero/0 (0.00s)
    --- PASS: TestPortNumberOrZero/1 (0.00s)
    --- PASS: TestPortNumberOrZero/8477 (0.00s)
    --- PASS: TestPortNumberOrZero/65535 (0.00s)
    --- PASS: TestPortNumberOrZero/65536 (0.00s)
    --- PASS: TestPortNumberOrZero/7000000 (0.00s)
=== RUN   TestRFC3339Time
=== RUN   TestRFC3339Time/#00
=== RUN   TestRFC3339Time/this_is_not_a_date
=== RUN   TestRFC3339Time/2000-01-01
=== RUN   TestRFC3339Time/2000-01-01T01:23:45
=== RUN   TestRFC3339Time/2000-01-01T01:23:45Z
=== RUN   TestRFC3339Time/2000-01-01T01:23:45+00:00
--- PASS: TestRFC3339Time (0.00s)
    --- PASS: TestRFC3339Time/#00 (0.00s)
    --- PASS: TestRFC3339Time/this_is_not_a_date (0.00s)
    --- PASS: TestRFC3339Time/2000-01-01 (0.00s)
    --- PASS: TestRFC3339Time/2000-01-01T01:23:45 (0.00s)
    --- PASS: TestRFC3339Time/2000-01-01T01:23:45Z (0.00s)
    --- PASS: TestRFC3339Time/2000-01-01T01:23:45+00:00 (0.00s)
=== RUN   TestRfc3339DateInFutureBy
=== RUN   TestRfc3339DateInFutureBy/empty
=== RUN   TestRfc3339DateInFutureBy/not_a_time
=== RUN   TestRfc3339DateInFutureBy/now_is_not_1_hour_ahead
=== RUN   TestRfc3339DateInFutureBy/now_+_7_hours_is_not_1_hour_ahead
=== RUN   TestRfc3339DateInFutureBy/now_+_7_min_is_7_min_ahead
=== RUN   TestRfc3339DateInFutureBy/now_+_8_min_is_at_least_7_min_ahead
--- PASS: TestRfc3339DateInFutureBy (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/empty (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/not_a_time (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/now_is_not_1_hour_ahead (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/now_+_7_hours_is_not_1_hour_ahead (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/now_+_7_min_is_7_min_ahead (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/now_+_8_min_is_at_least_7_min_ahead (0.00s)
=== RUN   TestURLIsHTTPS
=== RUN   TestURLIsHTTPS/#00
=== RUN   TestURLIsHTTPS/this_is_not_a_url
=== RUN   TestURLIsHTTPS/www.example.com
=== RUN   TestURLIsHTTPS/ftp://www.example.com
=== RUN   TestURLIsHTTPS/http://www.example.com
=== RUN   TestURLIsHTTPS/https://www.example.com
--- PASS: TestURLIsHTTPS (0.00s)
    --- PASS: TestURLIsHTTPS/#00 (0.00s)
    --- PASS: TestURLIsHTTPS/this_is_not_a_url (0.00s)
    --- PASS: TestURLIsHTTPS/www.example.com (0.00s)
    --- PASS: TestURLIsHTTPS/ftp://www.example.com (0.00s)
    --- PASS: TestURLIsHTTPS/http://www.example.com (0.00s)
    --- PASS: TestURLIsHTTPS/https://www.example.com (0.00s)
=== RUN   TestURLIsHTTPOrHTTPS
=== RUN   TestURLIsHTTPOrHTTPS/#00
=== RUN   TestURLIsHTTPOrHTTPS/this_is_not_a_url
=== RUN   TestURLIsHTTPOrHTTPS/www.example.com
=== RUN   TestURLIsHTTPOrHTTPS/ftp://www.example.com
=== RUN   TestURLIsHTTPOrHTTPS/http://www.example.com
=== RUN   TestURLIsHTTPOrHTTPS/https://www.example.com
--- PASS: TestURLIsHTTPOrHTTPS (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/#00 (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/this_is_not_a_url (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/www.example.com (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/ftp://www.example.com (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/http://www.example.com (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/https://www.example.com (0.00s)
=== RUN   TestUUID
=== RUN   TestUUID/#00
=== RUN   TestUUID/hello-world
=== RUN   TestUUID/00000000-0000-111-0000-000000000000
=== RUN   TestUUID/00000000-0000-0000-0000-000000000000
--- PASS: TestUUID (0.00s)
    --- PASS: TestUUID/#00 (0.00s)
    --- PASS: TestUUID/hello-world (0.00s)
    --- PASS: TestUUID/00000000-0000-111-0000-000000000000 (0.00s)
    --- PASS: TestUUID/00000000-0000-0000-0000-000000000000 (0.00s)
=== RUN   TestUrlWithScheme
=== RUN   TestUrlWithScheme/TestUrlWithScheme
--- PASS: TestUrlWithScheme (0.00s)
    --- PASS: TestUrlWithScheme/TestUrlWithScheme (0.00s)
=== RUN   TestVirtualNetworkRule_invalidNameValidation
--- PASS: TestVirtualNetworkRule_invalidNameValidation (0.00s)
=== RUN   TestResourceAzureRMPostgreSQLVirtualNetworkRule_validNameValidation
--- PASS: TestResourceAzureRMPostgreSQLVirtualNetworkRule_validNameValidation (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate	0.620s
```
@tombuildsstuff
Validation for the Shared Image Gallery Name
0a400ec 
```
$ go test -v ./azurerm/helpers/validate/
=== RUN   TestSharedImageGalleryName
=== RUN   TestSharedImageGalleryName/#00
=== RUN   TestSharedImageGalleryName/hello
=== RUN   TestSharedImageGalleryName/hello123
=== RUN   TestSharedImageGalleryName/hello.123
=== RUN   TestSharedImageGalleryName/hello,123
=== RUN   TestSharedImageGalleryName/hello_123
=== RUN   TestSharedImageGalleryName/hello-123
=== RUN   TestSharedImageGalleryName/eg0jovd9ln1m19flbdq429qsxpfh0hhn0hqqhwyaysmq8gyylzghgmwfdvgoxyqib6a8hyq1hpnhlyx
=== RUN   TestSharedImageGalleryName/inaamas6mjs23tax4k62ace3c0cuatutqr47zutxhj26jp4ih1x7ks7bc6mtor6vqx0snj71djj1p2ze
--- PASS: TestSharedImageGalleryName (0.00s)
    --- PASS: TestSharedImageGalleryName/#00 (0.00s)
    --- PASS: TestSharedImageGalleryName/hello (0.00s)
    --- PASS: TestSharedImageGalleryName/hello123 (0.00s)
    --- PASS: TestSharedImageGalleryName/hello.123 (0.00s)
    --- PASS: TestSharedImageGalleryName/hello,123 (0.00s)
    --- PASS: TestSharedImageGalleryName/hello_123 (0.00s)
    --- PASS: TestSharedImageGalleryName/hello-123 (0.00s)
    --- PASS: TestSharedImageGalleryName/eg0jovd9ln1m19flbdq429qsxpfh0hhn0hqqhwyaysmq8gyylzghgmwfdvgoxyqib6a8hyq1hpnhlyx (0.00s)
    --- PASS: TestSharedImageGalleryName/inaamas6mjs23tax4k62ace3c0cuatutqr47zutxhj26jp4ih1x7ks7bc6mtor6vqx0snj71djj1p2ze (0.00s)
=== RUN   TestSharedImageVersionName
=== RUN   TestSharedImageVersionName/#00
=== RUN   TestSharedImageVersionName/a.b.c
=== RUN   TestSharedImageVersionName/1.2.3
=== RUN   TestSharedImageVersionName/0.0.1
=== RUN   TestSharedImageVersionName/hello
=== RUN   TestSharedImageVersionName/1.2.3.4
=== RUN   TestSharedImageVersionName/hell0-there
--- PASS: TestSharedImageVersionName (0.00s)
    --- PASS: TestSharedImageVersionName/#00 (0.00s)
    --- PASS: TestSharedImageVersionName/a.b.c (0.00s)
    --- PASS: TestSharedImageVersionName/1.2.3 (0.00s)
    --- PASS: TestSharedImageVersionName/0.0.1 (0.00s)
    --- PASS: TestSharedImageVersionName/hello (0.00s)
    --- PASS: TestSharedImageVersionName/1.2.3.4 (0.00s)
    --- PASS: TestSharedImageVersionName/hell0-there (0.00s)
=== RUN   TestIPv4Address
=== RUN   TestIPv4Address/#00
=== RUN   TestIPv4Address/0.0.0.0
=== RUN   TestIPv4Address/1.2.3.no
=== RUN   TestIPv4Address/text
=== RUN   TestIPv4Address/1.2.3.4
=== RUN   TestIPv4Address/12.34.43.21
=== RUN   TestIPv4Address/100.123.199.0
=== RUN   TestIPv4Address/255.255.255.255
--- PASS: TestIPv4Address (0.00s)
    --- PASS: TestIPv4Address/#00 (0.00s)
    --- PASS: TestIPv4Address/0.0.0.0 (0.00s)
    --- PASS: TestIPv4Address/1.2.3.no (0.00s)
    --- PASS: TestIPv4Address/text (0.00s)
    --- PASS: TestIPv4Address/1.2.3.4 (0.00s)
    --- PASS: TestIPv4Address/12.34.43.21 (0.00s)
    --- PASS: TestIPv4Address/100.123.199.0 (0.00s)
    --- PASS: TestIPv4Address/255.255.255.255 (0.00s)
=== RUN   TestIPv4AddressOrEmpty
=== RUN   TestIPv4AddressOrEmpty/#00
=== RUN   TestIPv4AddressOrEmpty/0.0.0.0
=== RUN   TestIPv4AddressOrEmpty/1.2.3.no
=== RUN   TestIPv4AddressOrEmpty/text
=== RUN   TestIPv4AddressOrEmpty/1.2.3.4
=== RUN   TestIPv4AddressOrEmpty/12.34.43.21
=== RUN   TestIPv4AddressOrEmpty/100.123.199.0
=== RUN   TestIPv4AddressOrEmpty/255.255.255.255
--- PASS: TestIPv4AddressOrEmpty (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/#00 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/0.0.0.0 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/1.2.3.no (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/text (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/1.2.3.4 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/12.34.43.21 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/100.123.199.0 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/255.255.255.255 (0.00s)
=== RUN   TestMACAddress
=== RUN   TestMACAddress/#00
=== RUN   TestMACAddress/text_d
=== RUN   TestMACAddress/12:34:no
=== RUN   TestMACAddress/123:34:56:78:90:ab
=== RUN   TestMACAddress/12:34:56:78:90:NO
=== RUN   TestMACAddress/12:34:56:78:90:ab
=== RUN   TestMACAddress/ab:cd:ef:AB:CD:EF
--- PASS: TestMACAddress (0.00s)
    --- PASS: TestMACAddress/#00 (0.00s)
    --- PASS: TestMACAddress/text_d (0.00s)
    --- PASS: TestMACAddress/12:34:no (0.00s)
    --- PASS: TestMACAddress/123:34:56:78:90:ab (0.00s)
    --- PASS: TestMACAddress/12:34:56:78:90:NO (0.00s)
    --- PASS: TestMACAddress/12:34:56:78:90:ab (0.00s)
    --- PASS: TestMACAddress/ab:cd:ef:AB:CD:EF (0.00s)
=== RUN   TestPortNumber
=== RUN   TestPortNumber/-1
=== RUN   TestPortNumber/0
=== RUN   TestPortNumber/1
=== RUN   TestPortNumber/8477
=== RUN   TestPortNumber/65535
=== RUN   TestPortNumber/65536
=== RUN   TestPortNumber/7000000
--- PASS: TestPortNumber (0.00s)
    --- PASS: TestPortNumber/-1 (0.00s)
    --- PASS: TestPortNumber/0 (0.00s)
    --- PASS: TestPortNumber/1 (0.00s)
    --- PASS: TestPortNumber/8477 (0.00s)
    --- PASS: TestPortNumber/65535 (0.00s)
    --- PASS: TestPortNumber/65536 (0.00s)
    --- PASS: TestPortNumber/7000000 (0.00s)
=== RUN   TestPortNumberOrZero
=== RUN   TestPortNumberOrZero/-1
=== RUN   TestPortNumberOrZero/0
=== RUN   TestPortNumberOrZero/1
=== RUN   TestPortNumberOrZero/8477
=== RUN   TestPortNumberOrZero/65535
=== RUN   TestPortNumberOrZero/65536
=== RUN   TestPortNumberOrZero/7000000
--- PASS: TestPortNumberOrZero (0.00s)
    --- PASS: TestPortNumberOrZero/-1 (0.00s)
    --- PASS: TestPortNumberOrZero/0 (0.00s)
    --- PASS: TestPortNumberOrZero/1 (0.00s)
    --- PASS: TestPortNumberOrZero/8477 (0.00s)
    --- PASS: TestPortNumberOrZero/65535 (0.00s)
    --- PASS: TestPortNumberOrZero/65536 (0.00s)
    --- PASS: TestPortNumberOrZero/7000000 (0.00s)
=== RUN   TestRFC3339Time
=== RUN   TestRFC3339Time/#00
=== RUN   TestRFC3339Time/this_is_not_a_date
=== RUN   TestRFC3339Time/2000-01-01
=== RUN   TestRFC3339Time/2000-01-01T01:23:45
=== RUN   TestRFC3339Time/2000-01-01T01:23:45Z
=== RUN   TestRFC3339Time/2000-01-01T01:23:45+00:00
--- PASS: TestRFC3339Time (0.00s)
    --- PASS: TestRFC3339Time/#00 (0.00s)
    --- PASS: TestRFC3339Time/this_is_not_a_date (0.00s)
    --- PASS: TestRFC3339Time/2000-01-01 (0.00s)
    --- PASS: TestRFC3339Time/2000-01-01T01:23:45 (0.00s)
    --- PASS: TestRFC3339Time/2000-01-01T01:23:45Z (0.00s)
    --- PASS: TestRFC3339Time/2000-01-01T01:23:45+00:00 (0.00s)
=== RUN   TestRfc3339DateInFutureBy
=== RUN   TestRfc3339DateInFutureBy/empty
=== RUN   TestRfc3339DateInFutureBy/not_a_time
=== RUN   TestRfc3339DateInFutureBy/now_is_not_1_hour_ahead
=== RUN   TestRfc3339DateInFutureBy/now_+_7_hours_is_not_1_hour_ahead
=== RUN   TestRfc3339DateInFutureBy/now_+_7_min_is_7_min_ahead
=== RUN   TestRfc3339DateInFutureBy/now_+_8_min_is_at_least_7_min_ahead
--- PASS: TestRfc3339DateInFutureBy (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/empty (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/not_a_time (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/now_is_not_1_hour_ahead (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/now_+_7_hours_is_not_1_hour_ahead (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/now_+_7_min_is_7_min_ahead (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/now_+_8_min_is_at_least_7_min_ahead (0.00s)
=== RUN   TestURLIsHTTPS
=== RUN   TestURLIsHTTPS/#00
=== RUN   TestURLIsHTTPS/this_is_not_a_url
=== RUN   TestURLIsHTTPS/www.example.com
=== RUN   TestURLIsHTTPS/ftp://www.example.com
=== RUN   TestURLIsHTTPS/http://www.example.com
=== RUN   TestURLIsHTTPS/https://www.example.com
--- PASS: TestURLIsHTTPS (0.00s)
    --- PASS: TestURLIsHTTPS/#00 (0.00s)
    --- PASS: TestURLIsHTTPS/this_is_not_a_url (0.00s)
    --- PASS: TestURLIsHTTPS/www.example.com (0.00s)
    --- PASS: TestURLIsHTTPS/ftp://www.example.com (0.00s)
    --- PASS: TestURLIsHTTPS/http://www.example.com (0.00s)
    --- PASS: TestURLIsHTTPS/https://www.example.com (0.00s)
=== RUN   TestURLIsHTTPOrHTTPS
=== RUN   TestURLIsHTTPOrHTTPS/#00
=== RUN   TestURLIsHTTPOrHTTPS/this_is_not_a_url
=== RUN   TestURLIsHTTPOrHTTPS/www.example.com
=== RUN   TestURLIsHTTPOrHTTPS/ftp://www.example.com
=== RUN   TestURLIsHTTPOrHTTPS/http://www.example.com
=== RUN   TestURLIsHTTPOrHTTPS/https://www.example.com
--- PASS: TestURLIsHTTPOrHTTPS (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/#00 (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/this_is_not_a_url (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/www.example.com (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/ftp://www.example.com (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/http://www.example.com (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/https://www.example.com (0.00s)
=== RUN   TestUUID
=== RUN   TestUUID/#00
=== RUN   TestUUID/hello-world
=== RUN   TestUUID/00000000-0000-111-0000-000000000000
=== RUN   TestUUID/00000000-0000-0000-0000-000000000000
--- PASS: TestUUID (0.00s)
    --- PASS: TestUUID/#00 (0.00s)
    --- PASS: TestUUID/hello-world (0.00s)
    --- PASS: TestUUID/00000000-0000-111-0000-000000000000 (0.00s)
    --- PASS: TestUUID/00000000-0000-0000-0000-000000000000 (0.00s)
=== RUN   TestUrlWithScheme
=== RUN   TestUrlWithScheme/TestUrlWithScheme
--- PASS: TestUrlWithScheme (0.00s)
    --- PASS: TestUrlWithScheme/TestUrlWithScheme (0.00s)
=== RUN   TestVirtualNetworkRule_invalidNameValidation
--- PASS: TestVirtualNetworkRule_invalidNameValidation (0.00s)
=== RUN   TestResourceAzureRMPostgreSQLVirtualNetworkRule_validNameValidation
--- PASS: TestResourceAzureRMPostgreSQLVirtualNetworkRule_validNameValidation (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate	0.619s
```
@tombuildsstuff
Validation for the Shared Image name
2f42a42 
```
$ go test -v ./azurerm/helpers/validate/
=== RUN   TestSharedImageGalleryName
=== RUN   TestSharedImageGalleryName/#00
=== RUN   TestSharedImageGalleryName/hello
=== RUN   TestSharedImageGalleryName/hello123
=== RUN   TestSharedImageGalleryName/hello.123
=== RUN   TestSharedImageGalleryName/hello,123
=== RUN   TestSharedImageGalleryName/hello_123
=== RUN   TestSharedImageGalleryName/hello-123
=== RUN   TestSharedImageGalleryName/0xfbkai7139qjtelz8ngjk6128zlyho7qgtar8tk3wcygv2iyyrych0n4wx71bgtrywu9wgpusexvjv
=== RUN   TestSharedImageGalleryName/xa0t9ibyph7ydmewrdqlm7mc2tyhibxbzne00u30d8xli4mzbvr7rozuvklaekx3il43gqienkhmb7n0
--- PASS: TestSharedImageGalleryName (0.00s)
    --- PASS: TestSharedImageGalleryName/#00 (0.00s)
    --- PASS: TestSharedImageGalleryName/hello (0.00s)
    --- PASS: TestSharedImageGalleryName/hello123 (0.00s)
    --- PASS: TestSharedImageGalleryName/hello.123 (0.00s)
    --- PASS: TestSharedImageGalleryName/hello,123 (0.00s)
    --- PASS: TestSharedImageGalleryName/hello_123 (0.00s)
    --- PASS: TestSharedImageGalleryName/hello-123 (0.00s)
    --- PASS: TestSharedImageGalleryName/0xfbkai7139qjtelz8ngjk6128zlyho7qgtar8tk3wcygv2iyyrych0n4wx71bgtrywu9wgpusexvjv (0.00s)
    --- PASS: TestSharedImageGalleryName/xa0t9ibyph7ydmewrdqlm7mc2tyhibxbzne00u30d8xli4mzbvr7rozuvklaekx3il43gqienkhmb7n0 (0.00s)
=== RUN   TestSharedImageName
=== RUN   TestSharedImageName/#00
=== RUN   TestSharedImageName/hello
=== RUN   TestSharedImageName/hello123
=== RUN   TestSharedImageName/hello.123
=== RUN   TestSharedImageName/hello,123
=== RUN   TestSharedImageName/hello_123
=== RUN   TestSharedImageName/hello-123
=== RUN   TestSharedImageName/f0pe3ko7waqqzov1prgmsa16a11aob8ajmv8vvp399aqodr4uvizrj9hocuakghol9gbyfzedk9jci7
=== RUN   TestSharedImageName/j20heqhz242rm9crh3ex6lib013gmh2yknt2bj81cv6mzissfmj0uqevrx4rrygxp0cytpmei88w9962
--- PASS: TestSharedImageName (0.00s)
    --- PASS: TestSharedImageName/#00 (0.00s)
    --- PASS: TestSharedImageName/hello (0.00s)
    --- PASS: TestSharedImageName/hello123 (0.00s)
    --- PASS: TestSharedImageName/hello.123 (0.00s)
    --- PASS: TestSharedImageName/hello,123 (0.00s)
    --- PASS: TestSharedImageName/hello_123 (0.00s)
    --- PASS: TestSharedImageName/hello-123 (0.00s)
    --- PASS: TestSharedImageName/f0pe3ko7waqqzov1prgmsa16a11aob8ajmv8vvp399aqodr4uvizrj9hocuakghol9gbyfzedk9jci7 (0.00s)
    --- PASS: TestSharedImageName/j20heqhz242rm9crh3ex6lib013gmh2yknt2bj81cv6mzissfmj0uqevrx4rrygxp0cytpmei88w9962 (0.00s)
=== RUN   TestSharedImageVersionName
=== RUN   TestSharedImageVersionName/#00
=== RUN   TestSharedImageVersionName/a.b.c
=== RUN   TestSharedImageVersionName/1.2.3
=== RUN   TestSharedImageVersionName/0.0.1
=== RUN   TestSharedImageVersionName/hello
=== RUN   TestSharedImageVersionName/1.2.3.4
=== RUN   TestSharedImageVersionName/hell0-there
--- PASS: TestSharedImageVersionName (0.00s)
    --- PASS: TestSharedImageVersionName/#00 (0.00s)
    --- PASS: TestSharedImageVersionName/a.b.c (0.00s)
    --- PASS: TestSharedImageVersionName/1.2.3 (0.00s)
    --- PASS: TestSharedImageVersionName/0.0.1 (0.00s)
    --- PASS: TestSharedImageVersionName/hello (0.00s)
    --- PASS: TestSharedImageVersionName/1.2.3.4 (0.00s)
    --- PASS: TestSharedImageVersionName/hell0-there (0.00s)
=== RUN   TestIPv4Address
=== RUN   TestIPv4Address/#00
=== RUN   TestIPv4Address/0.0.0.0
=== RUN   TestIPv4Address/1.2.3.no
=== RUN   TestIPv4Address/text
=== RUN   TestIPv4Address/1.2.3.4
=== RUN   TestIPv4Address/12.34.43.21
=== RUN   TestIPv4Address/100.123.199.0
=== RUN   TestIPv4Address/255.255.255.255
--- PASS: TestIPv4Address (0.00s)
    --- PASS: TestIPv4Address/#00 (0.00s)
    --- PASS: TestIPv4Address/0.0.0.0 (0.00s)
    --- PASS: TestIPv4Address/1.2.3.no (0.00s)
    --- PASS: TestIPv4Address/text (0.00s)
    --- PASS: TestIPv4Address/1.2.3.4 (0.00s)
    --- PASS: TestIPv4Address/12.34.43.21 (0.00s)
    --- PASS: TestIPv4Address/100.123.199.0 (0.00s)
    --- PASS: TestIPv4Address/255.255.255.255 (0.00s)
=== RUN   TestIPv4AddressOrEmpty
=== RUN   TestIPv4AddressOrEmpty/#00
=== RUN   TestIPv4AddressOrEmpty/0.0.0.0
=== RUN   TestIPv4AddressOrEmpty/1.2.3.no
=== RUN   TestIPv4AddressOrEmpty/text
=== RUN   TestIPv4AddressOrEmpty/1.2.3.4
=== RUN   TestIPv4AddressOrEmpty/12.34.43.21
=== RUN   TestIPv4AddressOrEmpty/100.123.199.0
=== RUN   TestIPv4AddressOrEmpty/255.255.255.255
--- PASS: TestIPv4AddressOrEmpty (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/#00 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/0.0.0.0 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/1.2.3.no (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/text (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/1.2.3.4 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/12.34.43.21 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/100.123.199.0 (0.00s)
    --- PASS: TestIPv4AddressOrEmpty/255.255.255.255 (0.00s)
=== RUN   TestMACAddress
=== RUN   TestMACAddress/#00
=== RUN   TestMACAddress/text_d
=== RUN   TestMACAddress/12:34:no
=== RUN   TestMACAddress/123:34:56:78:90:ab
=== RUN   TestMACAddress/12:34:56:78:90:NO
=== RUN   TestMACAddress/12:34:56:78:90:ab
=== RUN   TestMACAddress/ab:cd:ef:AB:CD:EF
--- PASS: TestMACAddress (0.00s)
    --- PASS: TestMACAddress/#00 (0.00s)
    --- PASS: TestMACAddress/text_d (0.00s)
    --- PASS: TestMACAddress/12:34:no (0.00s)
    --- PASS: TestMACAddress/123:34:56:78:90:ab (0.00s)
    --- PASS: TestMACAddress/12:34:56:78:90:NO (0.00s)
    --- PASS: TestMACAddress/12:34:56:78:90:ab (0.00s)
    --- PASS: TestMACAddress/ab:cd:ef:AB:CD:EF (0.00s)
=== RUN   TestPortNumber
=== RUN   TestPortNumber/-1
=== RUN   TestPortNumber/0
=== RUN   TestPortNumber/1
=== RUN   TestPortNumber/8477
=== RUN   TestPortNumber/65535
=== RUN   TestPortNumber/65536
=== RUN   TestPortNumber/7000000
--- PASS: TestPortNumber (0.00s)
    --- PASS: TestPortNumber/-1 (0.00s)
    --- PASS: TestPortNumber/0 (0.00s)
    --- PASS: TestPortNumber/1 (0.00s)
    --- PASS: TestPortNumber/8477 (0.00s)
    --- PASS: TestPortNumber/65535 (0.00s)
    --- PASS: TestPortNumber/65536 (0.00s)
    --- PASS: TestPortNumber/7000000 (0.00s)
=== RUN   TestPortNumberOrZero
=== RUN   TestPortNumberOrZero/-1
=== RUN   TestPortNumberOrZero/0
=== RUN   TestPortNumberOrZero/1
=== RUN   TestPortNumberOrZero/8477
=== RUN   TestPortNumberOrZero/65535
=== RUN   TestPortNumberOrZero/65536
=== RUN   TestPortNumberOrZero/7000000
--- PASS: TestPortNumberOrZero (0.00s)
    --- PASS: TestPortNumberOrZero/-1 (0.00s)
    --- PASS: TestPortNumberOrZero/0 (0.00s)
    --- PASS: TestPortNumberOrZero/1 (0.00s)
    --- PASS: TestPortNumberOrZero/8477 (0.00s)
    --- PASS: TestPortNumberOrZero/65535 (0.00s)
    --- PASS: TestPortNumberOrZero/65536 (0.00s)
    --- PASS: TestPortNumberOrZero/7000000 (0.00s)
=== RUN   TestRFC3339Time
=== RUN   TestRFC3339Time/#00
=== RUN   TestRFC3339Time/this_is_not_a_date
=== RUN   TestRFC3339Time/2000-01-01
=== RUN   TestRFC3339Time/2000-01-01T01:23:45
=== RUN   TestRFC3339Time/2000-01-01T01:23:45Z
=== RUN   TestRFC3339Time/2000-01-01T01:23:45+00:00
--- PASS: TestRFC3339Time (0.00s)
    --- PASS: TestRFC3339Time/#00 (0.00s)
    --- PASS: TestRFC3339Time/this_is_not_a_date (0.00s)
    --- PASS: TestRFC3339Time/2000-01-01 (0.00s)
    --- PASS: TestRFC3339Time/2000-01-01T01:23:45 (0.00s)
    --- PASS: TestRFC3339Time/2000-01-01T01:23:45Z (0.00s)
    --- PASS: TestRFC3339Time/2000-01-01T01:23:45+00:00 (0.00s)
=== RUN   TestRfc3339DateInFutureBy
=== RUN   TestRfc3339DateInFutureBy/empty
=== RUN   TestRfc3339DateInFutureBy/not_a_time
=== RUN   TestRfc3339DateInFutureBy/now_is_not_1_hour_ahead
=== RUN   TestRfc3339DateInFutureBy/now_+_7_hours_is_not_1_hour_ahead
=== RUN   TestRfc3339DateInFutureBy/now_+_7_min_is_7_min_ahead
=== RUN   TestRfc3339DateInFutureBy/now_+_8_min_is_at_least_7_min_ahead
--- PASS: TestRfc3339DateInFutureBy (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/empty (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/not_a_time (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/now_is_not_1_hour_ahead (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/now_+_7_hours_is_not_1_hour_ahead (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/now_+_7_min_is_7_min_ahead (0.00s)
    --- PASS: TestRfc3339DateInFutureBy/now_+_8_min_is_at_least_7_min_ahead (0.00s)
=== RUN   TestURLIsHTTPS
=== RUN   TestURLIsHTTPS/#00
=== RUN   TestURLIsHTTPS/this_is_not_a_url
=== RUN   TestURLIsHTTPS/www.example.com
=== RUN   TestURLIsHTTPS/ftp://www.example.com
=== RUN   TestURLIsHTTPS/http://www.example.com
=== RUN   TestURLIsHTTPS/https://www.example.com
--- PASS: TestURLIsHTTPS (0.00s)
    --- PASS: TestURLIsHTTPS/#00 (0.00s)
    --- PASS: TestURLIsHTTPS/this_is_not_a_url (0.00s)
    --- PASS: TestURLIsHTTPS/www.example.com (0.00s)
    --- PASS: TestURLIsHTTPS/ftp://www.example.com (0.00s)
    --- PASS: TestURLIsHTTPS/http://www.example.com (0.00s)
    --- PASS: TestURLIsHTTPS/https://www.example.com (0.00s)
=== RUN   TestURLIsHTTPOrHTTPS
=== RUN   TestURLIsHTTPOrHTTPS/#00
=== RUN   TestURLIsHTTPOrHTTPS/this_is_not_a_url
=== RUN   TestURLIsHTTPOrHTTPS/www.example.com
=== RUN   TestURLIsHTTPOrHTTPS/ftp://www.example.com
=== RUN   TestURLIsHTTPOrHTTPS/http://www.example.com
=== RUN   TestURLIsHTTPOrHTTPS/https://www.example.com
--- PASS: TestURLIsHTTPOrHTTPS (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/#00 (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/this_is_not_a_url (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/www.example.com (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/ftp://www.example.com (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/http://www.example.com (0.00s)
    --- PASS: TestURLIsHTTPOrHTTPS/https://www.example.com (0.00s)
=== RUN   TestUUID
=== RUN   TestUUID/#00
=== RUN   TestUUID/hello-world
=== RUN   TestUUID/00000000-0000-111-0000-000000000000
=== RUN   TestUUID/00000000-0000-0000-0000-000000000000
--- PASS: TestUUID (0.00s)
    --- PASS: TestUUID/#00 (0.00s)
    --- PASS: TestUUID/hello-world (0.00s)
    --- PASS: TestUUID/00000000-0000-111-0000-000000000000 (0.00s)
    --- PASS: TestUUID/00000000-0000-0000-0000-000000000000 (0.00s)
=== RUN   TestUrlWithScheme
=== RUN   TestUrlWithScheme/TestUrlWithScheme
--- PASS: TestUrlWithScheme (0.00s)
    --- PASS: TestUrlWithScheme/TestUrlWithScheme (0.00s)
=== RUN   TestVirtualNetworkRule_invalidNameValidation
--- PASS: TestVirtualNetworkRule_invalidNameValidation (0.00s)
=== RUN   TestResourceAzureRMPostgreSQLVirtualNetworkRule_validNameValidation
--- PASS: TestResourceAzureRMPostgreSQLVirtualNetworkRule_validNameValidation (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate	0.619s
```
@tombuildsstuff
New Resource: azurerm_shared_image_gallery
ace552c
@tombuildsstuff
New Data Source: azurerm_shared_image_gallery
849041e
@tombuildsstuff
New Resource: azurerm_shared_image
04675aa
@tombuildsstuff
New Data Source: azurerm_shared_image
bc13a0e
@tombuildsstuff
Hooking up the resources
b9ea3b9
@tombuildsstuff
Adding a disclaimer about Shared Image Galleries being in Preview
bb473d7
@tombuildsstuff
New Resource: azurerm_shared_image_version
6403e77
@tombuildsstuff
New Data Source: azurerm_shared_image_version
e3bfe2d
@tombuildsstuff
Fixing the broken tests
913d219
@tombuildsstuff
Copy link
Contributor Author

Resource tests pass:

screenshot 2018-10-01 at 13 52 05

@tombuildsstuff
Copy link
Contributor Author

Data Source tests pass:

screenshot 2018-10-01 at 14 37 06

@tombuildsstuff tombuildsstuff merged commit 40b333f into master Oct 1, 2018
@tombuildsstuff tombuildsstuff deleted the shared-image-galleries branch October 1, 2018 01:38
tombuildsstuff added a commit that referenced this pull request Oct 1, 2018
@tombuildsstuff
Updating to include #1987
00aa6eb
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
new-resource service/images size/XXL
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @katbyte