Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user assigned and system managed identities on the same resource #2188

Merged
merged 3 commits into from
Nov 6, 2018

Conversation

rrudduck
Copy link
Contributor

For Virtual Machines and Virtual Machine Scale Sets it is possible to have both a system assigned identity along with multiple user assigned identities. This PR address this by allowing both to specified when the "SystemAssigned, UserAssigned" identity type is specified.

@ghost ghost added the size/L label Oct 30, 2018
@tombuildsstuff tombuildsstuff added this to the 1.19.0 milestone Nov 3, 2018
@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Nov 6, 2018

Ignoring a couple of temporary test failures the VMSS tests look good:

screenshot 2018-11-06 at 11 37 58

@tombuildsstuff
Copy link
Contributor

ignoring a known test failure - the VM tests pass:

screenshot 2018-11-06 at 12 26 52

@tombuildsstuff
Copy link
Contributor

@rrudduck I hope you don't mind I've rebased this / pushed a commit to update this to match the recent linting changes 👍

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @rrudduck 👍

@tombuildsstuff tombuildsstuff merged commit 411aa17 into hashicorp:master Nov 6, 2018
tombuildsstuff added a commit that referenced this pull request Nov 6, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants