Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable_builtin_logging to azurerm_function_app #2268

Merged
merged 3 commits into from
Nov 9, 2018

Conversation

JunyiYi
Copy link

@JunyiYi JunyiYi commented Nov 8, 2018

This PR fulfills the request in #1979.
The method used in the implementation is documented here: https://docs.microsoft.com/en-us/azure/azure-functions/functions-monitoring#disable-built-in-logging.

(fixes #1979)

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @JunyiYi

Thanks for this PR - on the whole this looks good to me; if we can fix the property name and document this (and the tests pass) we should be able to get this merged 👍

Thanks!

azurerm/resource_arm_function_app.go Outdated Show resolved Hide resolved
azurerm/resource_arm_function_app.go Outdated Show resolved Hide resolved
azurerm/resource_arm_function_app.go Outdated Show resolved Hide resolved
azurerm/resource_arm_function_app.go Outdated Show resolved Hide resolved
azurerm/resource_arm_function_app_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_function_app_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_function_app_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_function_app_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_function_app_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_function_app_test.go Show resolved Hide resolved
@JunyiYi JunyiYi changed the title Add built_in_logging_enabled to azurerm_function_app Add enable_builtin_logging to azurerm_function_app Nov 8, 2018
@katbyte
Copy link
Collaborator

katbyte commented Nov 9, 2018

Tests pass:
screen shot 2018-11-08 at 17 50 06

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JunyiYi,

Thanks for the quick updates! Looks like you've fixed all of toms comments and LGTM 👍

@katbyte katbyte merged commit b7eb318 into master Nov 9, 2018
@katbyte katbyte deleted the functionapp_builtinlog branch November 9, 2018 01:52
katbyte added a commit that referenced this pull request Nov 9, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make AzureWebJobsDashboard optional for Function Apps
3 participants